io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOBP-838] Remove receipt from list

Open LeleDallas opened this issue 1 year ago • 2 comments

This PR depends on

⚠️ This PR depends on #430 -> Please review the dependent PR before reviewing this ⚠️

Short description

This pull request introduces a new feature to hide receipts from the list

List of changes proposed in this pull request

  • Create a loading screen component for the payment section
  • Add hide button at the bottom of PaymentsTransactionBizEventsDetailsScreen
  • Update payment navigation route and saga

How to test

  • Go to payments section
  • Tap on an element
  • Scroll to the bottom and tap on Nascondi dalla lista
  • Verify if the element disappears after the redirect.

Preview

https://github.com/user-attachments/assets/de8adf32-d23d-4ea7-a1a9-b13dd62d88f6

@thisisjp would it make sense to set a minimum delay before displaying the Loading component? This could help avoid the component flashing on screen for very short loading times, leading to a smoother user experience.

LeleDallas avatar Oct 25 '24 14:10 LeleDallas

Affected stories

  • 🌟 IOBP-838: Come CIT voglio rimuovere una ricevuta dalla mia lista subtask of
    • IOBP-246: Evolutive sezione Pagamenti (ricevute)

Generated by :no_entry_sign: dangerJS against 90739c4ee4beb473ed444f44534f286d8d3cbcd2

pagopa-github-bot avatar Oct 25 '24 14:10 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 23.33333% with 46 lines in your changes missing coverage. Please review.

Project coverage is 47.07%. Comparing base (4f204b4) to head (90739c4). Report is 695 commits behind head on master.

Files with missing lines Patch % Lines
...ments/bizEventsTransaction/store/reducers/index.ts 0.00% 21 Missing :warning:
...n/saga/handleDisableBizEventsTransactionReceipt.ts 0.00% 15 Missing :warning:
.../components/PaymentsBizEventsHideReceiptButton.tsx 10.00% 9 Missing :warning:
...atures/payments/bizEventsTransaction/saga/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6334      +/-   ##
==========================================
- Coverage   48.42%   47.07%   -1.36%     
==========================================
  Files        1488     1832     +344     
  Lines       31617    37150    +5533     
  Branches     7669     8891    +1222     
==========================================
+ Hits        15311    17487    +2176     
- Misses      16238    19595    +3357     
  Partials       68       68              
Files with missing lines Coverage Δ
...ents/bizEventsTransaction/navigation/navigator.tsx 66.66% <ø> (ø)
...payments/bizEventsTransaction/navigation/routes.ts 100.00% <ø> (ø)
...eens/PaymentsTransactionBizEventsDetailsScreen.tsx 8.10% <ø> (ø)
...yments/bizEventsTransaction/store/actions/index.ts 100.00% <100.00%> (ø)
...tures/payments/bizEventsTransaction/utils/index.ts 76.92% <100.00%> (ø)
...atures/payments/bizEventsTransaction/saga/index.ts 0.00% <0.00%> (ø)
.../components/PaymentsBizEventsHideReceiptButton.tsx 10.00% <10.00%> (ø)
...n/saga/handleDisableBizEventsTransactionReceipt.ts 0.00% <0.00%> (ø)
...ments/bizEventsTransaction/store/reducers/index.ts 8.82% <0.00%> (ø)

... and 1451 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bc0c2a...90739c4. Read the comment docs.

codecov[bot] avatar Oct 25 '24 14:10 codecov[bot]