io-app icon indicating copy to clipboard operation
io-app copied to clipboard

fix(IT Wallet): [SIW-1772] Mixpanel properties and events tracking issues

Open ale-mazz opened this issue 1 year ago • 2 comments
trafficstars

Short description

This pull request includes several changes to the analytics tracking. Several issues related to updating some properties and events on mixpanel have been resolved.

List of changes proposed in this pull request

  • Removed eID properties update on focus, now it updates only when an action (creation or revocation) is completed.
  • Fixed a check issue in the tracking functions related to checking the presence of eID inside the store
  • Added some actions inside the machine to handle the tracking properly
  • Fixed an issue related to the async flow tracking (tracked multiple times)
  • Fixed an issue with the data share tracking (tracked multiple times)
  • Added eid bottom sheet tracking

How to test

Obtain a WI, add all the credentials, check on mixpanel that the various properties are updated correctly, remove the documents, check on mixpanel, finally revoke the WI, and check on mixpanel that all the properties have been updated correctly.

ale-mazz avatar Oct 22 '24 15:10 ale-mazz

Affected stories

  • 🐞 SIW-1772: [Mixpanel] Update properties/super properties rimozione documenti e revoca WI

Generated by :no_entry_sign: dangerJS against 8843c8d16aaba6817d87e8d1732106a45831907e

pagopa-github-bot avatar Oct 22 '24 15:10 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 33.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 47.07%. Comparing base (4f204b4) to head (8843c8d). Report is 654 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/itwallet/machine/credential/actions.ts 0.00% 6 Missing :warning:
ts/features/itwallet/analytics/index.ts 42.85% 4 Missing :warning:
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 0.00% 3 Missing :warning:
ts/features/itwallet/machine/eid/actions.ts 0.00% 3 Missing :warning:
ts/mixpanelConfig/profileProperties.ts 0.00% 2 Missing :warning:
ts/mixpanelConfig/superProperties.ts 0.00% 2 Missing :warning:
...common/components/ItwEidInfoBottomSheetContent.tsx 75.00% 1 Missing :warning:
...et/issuance/screens/ItwIssuanceEidResultScreen.tsx 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6321      +/-   ##
==========================================
- Coverage   48.42%   47.07%   -1.36%     
==========================================
  Files        1488     1810     +322     
  Lines       31617    36821    +5204     
  Branches     7669     8753    +1084     
==========================================
+ Hits        15311    17334    +2023     
- Misses      16238    19430    +3192     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
...s/ItwIssuanceCredentialAsyncContinuationScreen.tsx 65.90% <100.00%> (ø)
...et/lifecycle/saga/handleWalletInstanceResetSaga.ts 100.00% <100.00%> (ø)
ts/features/itwallet/machine/credential/machine.ts 92.85% <ø> (ø)
ts/features/itwallet/machine/eid/machine.ts 96.29% <ø> (ø)
.../newWallet/components/WalletEmptyScreenContent.tsx 71.42% <ø> (-11.91%) :arrow_down:
ts/features/newWallet/screens/WalletHomeScreen.tsx 85.18% <ø> (+0.97%) :arrow_up:
...common/components/ItwEidInfoBottomSheetContent.tsx 58.33% <75.00%> (ø)
...et/issuance/screens/ItwIssuanceEidResultScreen.tsx 8.33% <0.00%> (ø)
ts/mixpanelConfig/profileProperties.ts 24.48% <0.00%> (-5.95%) :arrow_down:
ts/mixpanelConfig/superProperties.ts 24.39% <0.00%> (-3.39%) :arrow_down:
... and 4 more

... and 1422 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b835b62...8843c8d. Read the comment docs.

codecov[bot] avatar Oct 23 '24 10:10 codecov[bot]