io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore(Cross): [IOAPPX-407] Remove instabug leftovers from native projects

Open LazyAfternoons opened this issue 1 year ago • 2 comments

Short description

This PR removes instabug, which is an old dependency, leftovers from native projects.

List of changes proposed in this pull request

  • Remove instabug from ProGuard rules on Android;
  • Remove instabug framework references from the iOS project.

How to test

# If you store DeriveData with relative path to the project folder, otherwise use Xcode to clean the build
> rm -rf ios/DerivedData 
> rm -rf ios/Pods
> cd ios && bundler exec pod install && cd .. 
> yarn react-native run-ios

> cd android && ./gradlew/clean
> yarn react-native run-android

This should also fix a warning we receive when building the iOS app.

LazyAfternoons avatar Oct 19 '24 12:10 LazyAfternoons

Affected stories

  • ⚙️ IOAPPX-407: [io-app] Rimozione rimanenze dipendenza instabug nei progetti nativi subtask of

Generated by :no_entry_sign: dangerJS against 347435bf34f55f34ad81d8e1098f040b1809f792

pagopa-github-bot avatar Oct 19 '24 12:10 pagopa-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.00%. Comparing base (4f204b4) to head (347435b). Report is 664 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6311      +/-   ##
==========================================
- Coverage   48.42%   47.00%   -1.43%     
==========================================
  Files        1488     1815     +327     
  Lines       31617    36902    +5285     
  Branches     7669     8898    +1229     
==========================================
+ Hits        15311    17346    +2035     
- Misses      16238    19490    +3252     
+ Partials       68       66       -2     

see 1440 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c43bc0b...347435b. Read the comment docs.

codecov[bot] avatar Oct 19 '24 13:10 codecov[bot]