io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore(Cross): [IOAPPX-347] Remove react-native-text-input-mask build phase script on iOS

Open LazyAfternoons opened this issue 1 year ago • 2 comments

Short description

This PR removes the build script patch for react-native-text-input-mask which is a removed dependency.

List of changes proposed in this pull request

  • Remove the workaround from the Build Phases.

How to test

# If you store DeriveData with relative path to the project folder, otherwise use Xcode to clean the build
> rm -rf ios/DerivedData 
> rm -rf ios/Pods
> cd ios && bundler exec pod install && cd .. 
> yarn react-native run-ios

This should also fix a warning we receive when building the iOS app.

LazyAfternoons avatar Oct 19 '24 10:10 LazyAfternoons

Affected stories

  • ⚙️ IOAPPX-347: [io-app] Rimozione script in build phase per react-native-text-input-mask su iOS subtask of

Generated by :no_entry_sign: dangerJS against a2c5e60fbf53853eea9cb3a480a49ff6fc5f2af6

pagopa-github-bot avatar Oct 19 '24 10:10 pagopa-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.41%. Comparing base (4f204b4) to head (a2c5e60). Report is 839 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6310      +/-   ##
==========================================
- Coverage   48.42%   48.41%   -0.01%     
==========================================
  Files        1488     1577      +89     
  Lines       31617    32183     +566     
  Branches     7669     7331     -338     
==========================================
+ Hits        15311    15583     +272     
- Misses      16238    16560     +322     
+ Partials       68       40      -28     

see 1718 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 274fa6f...a2c5e60. Read the comment docs.

codecov[bot] avatar Oct 19 '24 10:10 codecov[bot]