io-app
io-app copied to clipboard
fix(IT Wallet): [SIW-1723] Cards and documents not always stacked
Short description
This PR sets in wallet the stacked style to both ITWallet documents and other cards. The last of these two groups remains with not staked style, showing in full.
List of changes proposed in this pull request
- Set
isStackedprop ofwithWalletCardBaseComponentalways true - In
WalletCardsCategoryContainer, functionrenderItemI've retained the check for the last card to ensure that it remains not stacked - In
WalletCardsContainer.tsxI removed all the stacked prop fromItwCardsContainerandOtherCardsContainer
How to test
To test, you can use o io-api-dev-server and add as many payment methods as you want or use the production app and add both payment methods and ITW documents
Affected stories
- 🐞 SIW-1723: Incongruenza rappresentazione stacked card
Generated by :no_entry_sign: dangerJS against e2102128bc9ad6a962db991ec354c33be91ed084
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.97%. Comparing base (
4f204b4) to head (e210212). Report is 678 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #6309 +/- ##
==========================================
- Coverage 48.42% 46.97% -1.46%
==========================================
Files 1488 1821 +333
Lines 31617 36942 +5325
Branches 7669 8917 +1248
==========================================
+ Hits 15311 17354 +2043
- Misses 16238 19523 +3285
+ Partials 68 65 -3
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ts/features/design-system/core/DSWallet.tsx | 14.28% <ø> (-2.39%) |
:arrow_down: |
| ...s/newWallet/components/WalletCardBaseComponent.tsx | 100.00% <100.00%> (ø) |
|
| ...Wallet/components/WalletCardsCategoryContainer.tsx | 100.00% <100.00%> (ø) |
|
| ...ures/newWallet/components/WalletCardsContainer.tsx | 97.91% <100.00%> (+9.02%) |
:arrow_up: |
... and 1445 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ec7cd53...e210212. Read the comment docs.