io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat(IT Wallet): [SIW-1022] Add PIN/biometric authorization for eID store action

Open mastro993 opened this issue 1 year ago • 2 comments
trafficstars

[!WARNING] This PR depends on https://github.com/pagopa/io-app/pull/5780

Short description

This PR adds the PIN/biometric authorization request before proceeding to the eID store.

List of changes proposed in this pull request

  • Added useItwDismissalDialog hook which shows a confirmation dialog for the dismissal of the current procedure
  • Added ItwIssuanceEidResultScreen screen and routes
  • Added required locales
  • Within the ItwIssuanceEidPreviewScreen screen, it now show the PIN/biometric auth request when tapping the "Store" button.

How to test

Navigate to Profile > Playgrounds > IT Wallet > eID > SPID, select an IDP. In the eID preview screen, tap on "Store to wallet" button. You should be able to see the PIN/biometric authorization request.

Preview

https://github.com/pagopa/io-app/assets/6160324/5ef9a8a6-400a-4c17-8428-10fd2b28e37b

mastro993 avatar May 23 '24 10:05 mastro993

Affected stories

  • 🌟 SIW-1022: Come cittadino voglio autorizzare il salvataggio dell'eID nel portafoglio con PIN o biometrico subtask of

Generated by :no_entry_sign: dangerJS against 2c860f5edf7e0d7c79b9e96188ea6c79c6d8ca24

pagopa-github-bot avatar May 23 '24 10:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 49.60%. Comparing base (4f204b4) to head (fa68819). Report is 125 commits behind head on master.

:exclamation: Current head fa68819 differs from pull request most recent head 2c860f5

Please upload reports for the commit 2c860f5 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5792      +/-   ##
==========================================
+ Coverage   48.42%   49.60%   +1.17%     
==========================================
  Files        1488     1655     +167     
  Lines       31617    32932    +1315     
  Branches     7669     7940     +271     
==========================================
+ Hits        15311    16335    +1024     
- Misses      16238    16535     +297     
+ Partials       68       62       -6     
Files Coverage Δ
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
...features/itwallet/navigation/ItwStackNavigator.tsx 66.66% <ø> (ø)
ts/features/itwallet/navigation/routes.ts 100.00% <ø> (ø)
...et/issuance/screens/ItwIssuanceEidResultScreen.tsx 25.00% <25.00%> (ø)
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 9.09% <0.00%> (ø)
...es/itwallet/common/hooks/useItwDismissalDialog.tsx 12.50% <12.50%> (ø)

... and 615 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bb9606...2c860f5. Read the comment docs.

codecov[bot] avatar May 23 '24 11:05 codecov[bot]

:tada: All dependencies have been resolved !

dpulls[bot] avatar May 30 '24 14:05 dpulls[bot]