io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore(IT Wallet): [SIW-1153] Add SPID identification flow

Open mastro993 opened this issue 1 year ago • 2 comments

Short description

This PR adds the SPID identification flow for the IT Wallet credential issuance.

[!note] The result of the identification will be used to request the eID in an separate PR. This PR adds a generic Alert as a placeholder.

List of changes proposed in this pull request

  • Fixed an issue with keys in ItwMarkdown component
  • Added useItwIdpIdentification hook which handles SPID identification flow
  • Refactored ItwIdentificationIdpSelectionScreen to allow the SPID identification flow with the useItwIdpIdentification hook.

How to test

To test this PR with the io-dev-api-server, you need to make isFeatureFlagWithMinVersionEnabled("nativeLogin") function to return true. Then, navigate to Profile -> Playground -> IT Wallet -> eID -> SPID, select an IDP to start the identification.

Preview

https://github.com/pagopa/io-app/assets/6160324/6a84071e-8b14-45e7-913d-9dcf3ae4483a

mastro993 avatar May 22 '24 13:05 mastro993

Affected stories

  • ⚙️ SIW-1153: [APP] flusso di autenticazione con SPID subtask of

Generated by :no_entry_sign: dangerJS against f680f8ecfbdb2d949b96a3fba3a573c285a31ee1

pagopa-github-bot avatar May 22 '24 13:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 49.58%. Comparing base (4f204b4) to head (f680f8e). Report is 118 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5791      +/-   ##
==========================================
+ Coverage   48.42%   49.58%   +1.16%     
==========================================
  Files        1488     1649     +161     
  Lines       31617    32847    +1230     
  Branches     7669     7988     +319     
==========================================
+ Hits        15311    16288     +977     
- Misses      16238    16497     +259     
+ Partials       68       62       -6     
Files Coverage Δ
...s/features/itwallet/common/utils/itwErrorsUtils.ts 50.00% <ø> (ø)
...ures/itwallet/discovery/components/ItwMarkdown.tsx 53.33% <100.00%> (ø)
...features/itwallet/navigation/ItwStackNavigator.tsx 66.66% <ø> (ø)
...et/identification/hooks/useItwIdpIdentification.ts 13.33% <13.33%> (ø)
...on/screens/ItwIdentificationIdpSelectionScreen.tsx 8.33% <7.14%> (ø)

... and 594 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50fa6cf...f680f8e. Read the comment docs.

codecov[bot] avatar May 22 '24 14:05 codecov[bot]