io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IOBP-644] Add other onboardable method filters

Open Hantex9 opened this issue 1 year ago • 2 comments

Short description

This PR adds a filter on onboardable methods in the add new method section and a filter on methods with guest payment

List of changes proposed in this pull request

  • Upgraded the API definitions of e-commerce & walletv3;
  • Created a utility function to filter the onboardable methods and guest payment methods;

How to test

  • Check out this PR: https://github.com/pagopa/io-dev-api-server/pull/379
  • Try the new payment checkout flow and onboarding flow with the feature flag enabled
  • You should be able to complete all the required steps with any error;

Hantex9 avatar May 20 '24 18:05 Hantex9

Affected stories

  • ⚙️ IOBP-644: [Metodi di pagamento] Adeguamento logiche di visualizzazione metodi in app durante i flussi di on-boarding e pagamento subtask of
    • IOBP-197: [MVP] Integrazione IO-ecommerce PagoPA (Flusso pagamento)

Generated by :no_entry_sign: dangerJS against 484c9dee4696db84c098dd22493889895c843c2f

pagopa-github-bot avatar May 20 '24 18:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 49.71%. Comparing base (4f204b4) to head (484c9de). Report is 109 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5785      +/-   ##
==========================================
+ Coverage   48.42%   49.71%   +1.28%     
==========================================
  Files        1488     1630     +142     
  Lines       31617    32423     +806     
  Branches     7669     7789     +120     
==========================================
+ Hits        15311    16118     +807     
- Misses      16238    16250      +12     
+ Partials       68       55      -13     
Files Coverage Δ
...tures/payments/onboarding/store/selectors/index.ts 45.45% <0.00%> (+12.12%) :arrow_up:
...ayments/checkout/store/selectors/paymentMethods.ts 24.39% <0.00%> (ø)
ts/features/payments/onboarding/utils/index.ts 66.66% <33.33%> (-33.34%) :arrow_down:
ts/features/payments/checkout/utils/index.ts 40.00% <25.00%> (-60.00%) :arrow_down:

... and 566 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e6759f...484c9de. Read the comment docs.

codecov[bot] avatar May 20 '24 19:05 codecov[bot]