io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOPID-1521,IOPID-1522,IOPID-1523] Integrate new DS in Profile section

Open ChrisMattew opened this issue 1 year ago • 4 comments
trafficstars

Short description

Integrate new DS in Profile section and Tax Code screen.

List of changes proposed in this pull request

  • Integration of new DS in Profile section;
  • Implementation of new Banner in Profile section to guide the user to the new tax code section;
  • In "Your Data" section:
    • Integration of new DS;
    • Addition of new Tax Code list item.
  • Integration of new DS in Fiscal Code section

Test

E2E

[!Tip] Run e2e tests

Screens

iOS & Android

iOS Android
A11Y - iOS & Android

iOS Android

How to test

  • Navigate into the Profile section to check the new DS. The new Banner** should be visible on top of the screen.
  • Clicking on the new Banner it will redirect you to the "Your Data" screen (even this one with the new DS applied).
  • Once in the "Your Data" screen if you click the cta "Show" displayed in the Tax Code list item you will be redirected to the new Tax Code screen accordingly with the new DS directives.

[!Important] Once in the Tax Code screen, if the brightness of your device is not at the maximum level, it will automatically be brought to the maximum level, in this case exiting this screen will restore the brightness of your device as previously set.

[!Note] ** Once the Banner is closed, it shouldn't appear anymore, even if you close and re-open the app. But don't worry, you will still be able to navigate into the "Your Data" screen by clicking on the dedicated item on the list.

ChrisMattew avatar May 16 '24 14:05 ChrisMattew

Warnings
:warning:

Multiple stories with different types are associated with this Pull request. Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • 🌟 IOPID-1521: [DS-Profile][APP] Main Screen subtask of
  • 🌟 IOPID-1522: [DS-Profile] [APP] CF Screen subtask of
  • 🌟 IOPID-1523: [DS-Profile][APP] Main Data Screen subtask of

Generated by :no_entry_sign: dangerJS against 301629404d6264ff4af5f06a9e9bf6cbbedcdb4e

pagopa-github-bot avatar May 16 '24 15:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 79.03226% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 49.82%. Comparing base (4f204b4) to head (3016294). Report is 104 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5778      +/-   ##
==========================================
+ Coverage   48.42%   49.82%   +1.39%     
==========================================
  Files        1488     1627     +139     
  Lines       31617    32322     +705     
  Branches     7669     7865     +196     
==========================================
+ Hits        15311    16103     +792     
+ Misses      16238    16156      -82     
+ Partials       68       63       -5     
Files Coverage Δ
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/profileSettings/store/actions/index.ts 100.00% <100.00%> (ø)
.../features/profileSettings/store/selectors/index.ts 100.00% <100.00%> (ø)
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (+26.66%) :arrow_up:
ts/navigation/TabNavigator.tsx 9.09% <ø> (-1.72%) :arrow_down:
.../navigation/components/HeaderFirstLevelHandler.tsx 6.45% <ø> (ø)
ts/screens/profile/FiscalCodeScreen.tsx 100.00% <100.00%> (+81.48%) :arrow_up:
ts/store/reducers/index.ts 40.74% <ø> (ø)
...s/features/profileSettings/store/reducers/index.ts 85.71% <85.71%> (ø)
ts/screens/profile/ProfileDataScreen.tsx 92.59% <91.30%> (+22.00%) :arrow_up:
... and 2 more

... and 543 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17fdb27...3016294. Read the comment docs.

codecov[bot] avatar May 16 '24 15:05 codecov[bot]

@mariateresaventura copy review needed 🙏🏼

ChrisMattew avatar May 21 '24 14:05 ChrisMattew

@mariateresaventura copy review needed 🙏🏼

Done!

mariateresaventura avatar May 23 '24 06:05 mariateresaventura

@mariateresaventura copy review needed! 🙏🏼

ChrisMattew avatar May 28 '24 10:05 ChrisMattew