io-app
io-app copied to clipboard
feat: [IOBP-637,IOBP-440] New transactions list and details with biz events integration
Short description
This PR implements the new transaction list and transaction details powered by biz-events by managing more information such as logo, payment method used, cart type transactions and so on.
List of changes proposed in this pull request
- Added a new feature-folder within the “payments” folder;
- Added sagas, reducers, store, screens;
- Added selectors for getting latest transactions;
- Added a transaction list with server-side pagination;
- Added biz-events API definitions reference;
Why is a new feature-folder being created?
Because the old transactions feature will still have to be available since in addition to biz-events in an early transition there will also be dated transactions
How to test
- Checkout this PR on the io-dev-api-server: https://github.com/pagopa/io-dev-api-server/pull/369
- Now You can test this feature on the main landing page of the new payment section. You should be able to initially see the last 10 transactions made. In the upper right hand corner you can see all transactions performed via the “See All” call-to-action, which will show a list of transactions paged 10 per page. If you tap on a transaction, you can access its detail
Preview
| Warnings | |
|---|---|
| :warning: |
Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: |
Affected stories
- ⚙️ IOBP-637: Creazione delle schermate biz-events in app IO
subtask of
- 🌟 IOBP-440: Recupero lista transazioni BIZ Event
- 🌟 IOBP-440: Recupero lista transazioni BIZ Event
subtask of
- ⚡ IOBP-540: Integrazione IO-BIZ Event
Generated by :no_entry_sign: dangerJS against 544b312ec9c79f2f14d5905e36fe9f912054b4e7
Codecov Report
Attention: Patch coverage is 21.94444% with 281 lines in your changes missing coverage. Please review.
Project coverage is 49.63%. Comparing base (
4f204b4) to head (544b312). Report is 150 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5768 +/- ##
==========================================
+ Coverage 48.42% 49.63% +1.21%
==========================================
Files 1488 1675 +187
Lines 31617 33149 +1532
Branches 7669 7955 +286
==========================================
+ Hits 15311 16455 +1144
- Misses 16238 16643 +405
+ Partials 68 51 -17
| Files | Coverage Δ | |
|---|---|---|
| ...payments/bizEventsTransaction/navigation/routes.ts | 100.00% <100.00%> (ø) |
|
| ...yments/bizEventsTransaction/store/actions/index.ts | 100.00% <100.00%> (ø) |
|
| ...tures/payments/bizEventsTransaction/utils/types.ts | 100.00% <100.00%> (ø) |
|
| ...s/features/payments/common/store/reducers/index.ts | 100.00% <ø> (ø) |
|
| ts/features/payments/common/utils/index.ts | 46.15% <100.00%> (+6.49%) |
:arrow_up: |
| ...tures/payments/home/screens/PaymentsHomeScreen.tsx | 94.44% <ø> (ø) |
|
| ts/navigation/AuthenticatedStackNavigator.tsx | 10.00% <ø> (-1.12%) |
:arrow_down: |
| ts/navigation/params/AppParamsList.ts | 100.00% <ø> (ø) |
|
| ...ents/bizEventsTransaction/navigation/navigator.tsx | 66.66% <66.66%> (ø) |
|
| ts/features/payments/home/store/selectors/index.ts | 86.66% <80.00%> (-13.34%) |
:arrow_down: |
| ... and 18 more |
... and 649 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7ea4af1...544b312. Read the comment docs.
I don't like
biz-event-transactionsas sub-feature name. Can we usetransactionList? It's more concise and will be placed just right after thetransactionfeature.
I am afraid that it might be too misleading between the old “transactions” and the new “transactionsList,” which is why I preferred to indicate the wording “biz-events” to understand the difference between the two. (In the future, when the old transactions are all migrated to biz-events, the old transactions sub-folder can be deleted and this current subfolder “biz-events-transaction” will be renamed to “transactions”)
I don't like
biz-event-transactionsas sub-feature name. Can we usetransactionList? It's more concise and will be placed just right after thetransactionfeature.I am afraid that it might be too misleading between the old “transactions” and the new “transactionsList,” which is why I preferred to indicate the wording “biz-events” to understand the difference between the two. (In the future, when the old transactions are all migrated to biz-events, the old transactions sub-folder can be deleted and this current subfolder “biz-events-transaction” will be renamed to “transactions”)
I understand. In this case, the name should use the camelCase instead of the kebab-case. So we must use bizEventsTransactions
I don't like
biz-event-transactionsas sub-feature name. Can we usetransactionList? It's more concise and will be placed just right after thetransactionfeature.I am afraid that it might be too misleading between the old “transactions” and the new “transactionsList,” which is why I preferred to indicate the wording “biz-events” to understand the difference between the two. (In the future, when the old transactions are all migrated to biz-events, the old transactions sub-folder can be deleted and this current subfolder “biz-events-transaction” will be renamed to “transactions”)
I understand. In this case, the name should use the camelCase instead of the kebab-case. So we must use
bizEventsTransactions
Addressed into edc59305dcf6f9068a18e1dd53f4856aa1e9c8a8