io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOPID-1548] DS add new cie errors

Open Ladirico opened this issue 1 year ago • 4 comments

Short description

Add CIE errors screens. Change generic error design and add errors 22 and 1001.

List of changes proposed in this pull request

  • Fix the incorrect visualization of error 1002 (using a custom WizardScreen -> create component CustomWizardScreen)
  • Add tests
  • Add screens for error 1001 and 22 and generic
  • Add new route to visualize CIE error
  • Change CieConsentDataUsageScreen from class component to function component
  • Change folder of UnlockAccessScreen from onboarding to authentication

[!Tip] Run e2e tests

[!Note]

  1. To test all error cases, I used Proxyman by forcing the response that should come from the BE. So the flow is not correct, in fact error 1002 is not displayed with the L3 access type
  2. The A11Y test were not realised because the same components were tested in many other PR
  3. I modified the component for error 1002, which is in common with SPID, so I additionally tested the spid flow for error 1002.

iOS screens

Error 1001 Error 1002 Error 22 Error Generic SPID Error 1002

Android screens

Error 1001 Error 1002 Error 22 Error Generic SPID Error 1002

How to test

IOS: before building the app run yarn cie-ios:prod and then perform authentication flow with CIE Android: run the application using .env.production

Ladirico avatar May 08 '24 08:05 Ladirico

Affected stories

Generated by :no_entry_sign: dangerJS against b293956cbd72ef32e42e69aa298bbe4cb6bb5dea

pagopa-github-bot avatar May 08 '24 08:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 34.65347% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 49.56%. Comparing base (4f204b4) to head (b293956). Report is 94 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5750      +/-   ##
==========================================
+ Coverage   48.42%   49.56%   +1.14%     
==========================================
  Files        1488     1623     +135     
  Lines       31617    32181     +564     
  Branches     7669     7734      +65     
==========================================
+ Hits        15311    15952     +641     
+ Misses      16238    16175      -63     
+ Partials       68       54      -14     
Files Coverage Δ
ts/navigation/AuthenticationNavigator.tsx 40.00% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
...s/screens/authentication/UnlockAccessComponent.tsx 94.44% <100.00%> (ø)
ts/screens/authentication/UnlockAccessScreen.tsx 100.00% <100.00%> (ø)
ts/screens/authentication/IdpLoginScreen.tsx 4.04% <0.00%> (+0.04%) :arrow_up:
.../authentication/cie/components/AuthErrorScreen.tsx 83.33% <83.33%> (ø)
ts/components/screens/CustomWizardScreen.tsx 85.71% <85.71%> (ø)
.../screens/authentication/cie/CieAuthErrorScreen.tsx 11.11% <11.11%> (ø)
...s/authentication/cie/CieConsentDataUsageScreen.tsx 3.33% <3.57%> (-3.81%) :arrow_down:

... and 529 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09693da...b293956. Read the comment docs.

codecov[bot] avatar May 08 '24 09:05 codecov[bot]

@mariateresaventura Could you please do the copy review? 😁🙏🏼

Ladirico avatar May 15 '24 13:05 Ladirico

@mariateresaventura Could you please do the copy review? 😁🙏🏼

Done!

mariateresaventura avatar May 15 '24 17:05 mariateresaventura