io-app
io-app copied to clipboard
feat: [IOPID-1723] Revamp EIC PIN Errors with the new DS
Short description
This PR adopt the new DS to CieWrongCiePinScreen.
Demo
| π€ | π |
|---|---|
A11y
| π€ | π |
|---|---|
List of changes proposed in this pull request
- Adopt the new DS to
CieWrongCiePinScreen. - Remove
CiePinLockedTemporarilyScreenin favor ofCieWrongCiePinScreen. - Add screen tests (TODO)
How to test
Run the app on Android and iOS physical devices. Try to login with EIC and fail to insert a valid PIN for three times.
Affected stories
- π IOPID-1723: [DS-CIE][APP] Errori lettura CIE (Common iOS/Android)
subtask of
- β‘ IOPID-1722: DS - Entra con CIE
Generated by :no_entry_sign: dangerJS against 9ede8bef0cd68b0c3f54da9286dc65e986f9e771
Codecov Report
Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 49.02%. Comparing base (
4f204b4) to head (9ede8be). Report is 70 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5748 +/- ##
==========================================
+ Coverage 48.42% 49.02% +0.59%
==========================================
Files 1488 1609 +121
Lines 31617 32320 +703
Branches 7669 7886 +217
==========================================
+ Hits 15311 15845 +534
- Misses 16238 16408 +170
+ Partials 68 67 -1
| Files | Coverage Ξ | |
|---|---|---|
| ts/navigation/AuthenticationNavigator.tsx | 40.00% <ΓΈ> (ΓΈ) |
|
| ...screens/authentication/cie/CieCardReaderScreen.tsx | 5.59% <0.00%> (+0.06%) |
:arrow_up: |
| ...creens/authentication/cie/CieWrongCiePinScreen.tsx | 80.95% <80.95%> (+72.61%) |
:arrow_up: |
... and 234 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update 47b6b40...9ede8be. Read the comment docs.
@mariateresaventura copy review needed π
@mariateresaventura copy review needed π
Done!