io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IOPAE-1126] Add failure state to InstitutionServicesScreen

Open adelloste opened this issue 1 year ago • 2 comments

This PR depends on https://github.com/pagopa/io-app/pull/5642

Short description

This PR handles failure state when fetching the institution's services.

List of changes proposed in this pull request

  • added InstitutionServicesFailure component
  • updated InstitutionServicesScreen to manage failure state

How to test

Using io-dev-api-server, checkout this PR https://github.com/pagopa/io-dev-api-server/pull/372, set the status code to 500. Navigate to the services tab and tap on an institution. Check the error card

adelloste avatar May 06 '24 09:05 adelloste

Affected stories

  • ⚙️ IOPAE-1126: [APP] Aggiungere screen di errore subtask of
    • 🌟 IOPAE-1107: [MVP0] Come utente voglio vedere una Pagina Ente con tutti i servizi dell'ente

Generated by :no_entry_sign: dangerJS against 26cffcb36ec2c608f6e20e57560488d9d471d650

pagopa-github-bot avatar May 06 '24 09:05 pagopa-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.04%. Comparing base (4f204b4) to head (26cffcb). Report is 54 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
+ Coverage   48.42%   49.04%   +0.62%     
==========================================
  Files        1488     1597     +109     
  Lines       31617    32112     +495     
  Branches     7669     7832     +163     
==========================================
+ Hits        15311    15750     +439     
- Misses      16238    16294      +56     
  Partials       68       68              
Files Coverage Δ
...titution/components/InstitutionServicesFailure.tsx 100.00% <100.00%> (ø)
.../components/InstitutionServicesScreenComponent.tsx 90.00% <100.00%> (ø)
.../institution/screens/InstitutionServicesScreen.tsx 80.55% <100.00%> (ø)

... and 199 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5010ac...26cffcb. Read the comment docs.

codecov[bot] avatar May 06 '24 10:05 codecov[bot]