io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [PE-552] Revamp CGN merchant details screen

Open Hantex9 opened this issue 1 year ago • 2 comments

Short description

This PR implements the new DS on CGN merchant detail screen.

Design of reference

https://www.figma.com/file/yOoBGDr1MJpa0LY5lDUFSd/IOapp_CartaGiovaniNazionale?type=design&node-id=4405-100549&mode=design&t=YXJlUj57xQtDYAm8-4

N.B: The contact section designed inside the Figma with all the merchant contacts is a feature that will be implemented as soon as the backend gives us that information.

List of changes proposed in this pull request

  • Added the new DS components inside the merchant detail screen
  • Added a skeleton placeholder while the merchant details are loading

How to test

  • Before you test this pull request, run yarn install to update your design system library to the latest one.
  • With the CGN card onboarded, navigate through all the flows from the CGN details page until you reach the merchant list, as soon as you tap on it you should be able to see the new design.

Preview

https://github.com/pagopa/io-app/assets/34343582/6a4602e4-9dc3-4f97-aee2-222db8d73d93

Hantex9 avatar May 02 '24 16:05 Hantex9

Affected stories

  • 🌟 PE-552: [FE] Revamp schermate dettaglio operatore subtask of
    • PE-511: CGN - Adeguamento flussi/schermate a nuovo DS 2.0

Generated by :no_entry_sign: dangerJS against 71355acfe7456255c937fee72a3a31377ff8b2c3

pagopa-github-bot avatar May 02 '24 16:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 12.04819% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 48.97%. Comparing base (4f204b4) to head (71355ac). Report is 57 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5738      +/-   ##
==========================================
+ Coverage   48.42%   48.97%   +0.54%     
==========================================
  Files        1488     1599     +111     
  Lines       31617    32172     +555     
  Branches     7669     7732      +63     
==========================================
+ Hits        15311    15755     +444     
- Misses      16238    16359     +121     
+ Partials       68       58      -10     
Files Coverage Δ
...s/bonus/cgn/components/detail/CgnCardComponent.tsx 90.90% <ø> (ø)
.../components/merchants/CgnMerchantsDiscountItem.tsx 50.00% <ø> (+10.00%) :arrow_up:
ts/features/bonus/cgn/navigation/navigator.tsx 70.00% <ø> (ø)
...checkout/screens/WalletPaymentPickMethodScreen.tsx 1.56% <ø> (-4.75%) :arrow_down:
...us/cgn/components/merchants/CgnAddressListItem.tsx 16.66% <16.66%> (ø)
...nus/cgn/components/merchants/CgnModuleDiscount.tsx 10.00% <10.00%> (ø)
.../cgn/screens/merchants/CgnMerchantDetailScreen.tsx 12.12% <12.76%> (-0.70%) :arrow_down:

... and 215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fd9378...71355ac. Read the comment docs.

codecov[bot] avatar May 02 '24 19:05 codecov[bot]