io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOPID-1812] Remove the CTA from `CiePinScreen`

Open shadowsheep1 opened this issue 1 year ago β€’ 2 comments

Short description

This PR removes the CTA from CiePinScreen.

Demo

πŸ€– 🍏

List of changes proposed in this pull request

  • Bump DS version to 1.36.6 where the OTPInput has the autoFocus prop.
  • Remove the CTA from CiePinScreen.

How to test

Run the app on both Android and iOS physical devices and try to login with EIC. When you navigate to the CiePinScreen, you should see the VirtualKeyboard open and ready to input the EIC pin.

shadowsheep1 avatar May 02 '24 10:05 shadowsheep1

Affected stories

  • 🌟 IOPID-1812: [DS-CIE][APP] Finalizzazione schermata CIE Pin Screen senza CTA subtask of

Generated by :no_entry_sign: dangerJS against 32c320dd0519fe7e59aaf1a4597c7e3c64f236a0

pagopa-github-bot avatar May 02 '24 10:05 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 48.88%. Comparing base (4f204b4) to head (32c320d). Report is 45 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5735      +/-   ##
==========================================
+ Coverage   48.42%   48.88%   +0.45%     
==========================================
  Files        1488     1588     +100     
  Lines       31617    31969     +352     
  Branches     7669     7807     +138     
==========================================
+ Hits        15311    15628     +317     
- Misses      16238    16273      +35     
  Partials       68       68              
Files Coverage Ξ”
ts/screens/authentication/cie/CiePinScreen.tsx 7.69% <0.00%> (-4.08%) :arrow_down:

... and 150 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6d01753...32c320d. Read the comment docs.

codecov[bot] avatar May 02 '24 10:05 codecov[bot]