io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOCOM-882] New DS on a paid payment screen for a cancelled PN message

Open Vangaorth opened this issue 1 year ago • 2 comments

Short description

This PR adds the PN paid notice screen with the new DS (for a cancelled PN message).

old new
Screenshot 2024-03-22 at 18 27 18 Simulator Screenshot - iPhone 15 - 2024-03-22 at 18 00 42

List of changes proposed in this pull request

  • New PaidPaymentScreen screen

How to test

Using the io-dev-api-server, generate a cancelled PN message with some paid payments. Since the payments section has not been ported to the new DS yet, flip the isDesignSystemEnabled value on the PN navigator for the PN message details screen. Select a PN message that is cancelled, select one of its payments and check the new screen.

Vangaorth avatar Mar 22 '24 17:03 Vangaorth

Affected stories

  • 🌟 IOCOM-882: [App] Adattare UI pagamento effettuato su notifica annullata SEND subtask of
    • IOCOM-816: Adottare il nuovo design system nella schermata riepilogo pagamento effettuato su notifica annullata SEND

Generated by :no_entry_sign: dangerJS against bfc21dbffe517e72961c980b6b12d10f4a7fb810

pagopa-github-bot avatar Mar 22 '24 17:03 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.16%. Comparing base (c4ee44c) to head (bfc21db).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5621   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files        1453     1454    +1     
  Lines       30955    30962    +7     
  Branches     7517     7518    +1     
=======================================
+ Hits        14908    14913    +5     
- Misses      15979    15981    +2     
  Partials       68       68           
Files Coverage Δ
ts/features/pn/navigation/navigator.tsx 18.18% <0.00%> (-1.82%) :arrow_down:
ts/features/pn/screens/PaidPaymentScreen.tsx 80.00% <75.00%> (+2.22%) :arrow_up:
ts/features/pn/screens/LegacyPaidPaymentScreen.tsx 80.00% <80.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4ee44c...bfc21db. Read the comment docs.

codecov[bot] avatar Mar 22 '24 17:03 codecov[bot]