io-app
io-app copied to clipboard
feat: [IOPID-1566,IOPID-1567,IOPID-1570] Adopt the new DS to FL modals
Short description
This PR addresses the redesign of FastLogin Modals by adopting the new DS.
[!TIP] Review Privacy ✅ Translations ⌛️
List of changes proposed in this pull request
- Rename
AskUserInteractionScreentoAskUserInteractionScreen, removing the "r" typo. - Adopt of the new DS to
AskUserInteractionScreenthroughOperationResultScreenContent.- This addresses all the three modals of FL refresh flow (with pin, without pin, and transient error).
- Update tests to fit the new
AskUserInteractionScreenUI. - Remove the countdown and close button feature because they've been never used.
🎦 Demo 🎦
| 🤖 session refresh error | 🤖 no pin session expiration | 🤖 with pin session expiration |
|---|---|---|
| 🍏 session refresh error | 🍏 no pin session expiration | 🍏 with pin session expiration |
|---|---|---|
How to test
- Test FL session refresh during a first onboarding where you didn't have set your pin yet (TIP wait for the session to be expired before accepting ToS): check the new UI and to be logged out by pressing the CTA.
- Log in again and you'd be navigate to the onboarding scree you where before.
- Test FL session refresh: check the new UI and to be successful in refreshing your session by pressing the CTA.
- Test FL session error (TIP trigger a session refresh and before pressing the CTA kill the dev server).
| Warnings | |
|---|---|
| :warning: |
Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: |
Affected stories
- 🌟 IOPID-1566: [DS-Modal] Fast Login - Sessione Scaduta con codice
subtask of
- ⚡ IOPID-1515: DS - Modali ed errori e refresh sessione (16)
- 🌟 IOPID-1567: [DS-Modal] Fast Login - Sessione Scaduta senza codice
subtask of
- ⚡ IOPID-1515: DS - Modali ed errori e refresh sessione (16)
- 🌟 IOPID-1570: [DS-Modal] Fast Login - Errore nell'autenticazione
subtask of
- ⚡ IOPID-1515: DS - Modali ed errori e refresh sessione (16)
Generated by :no_entry_sign: dangerJS against d1b62dcdeb07e20182336b7d026a386fd5756563
Codecov Report
Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 48.09%. Comparing base (
49e2fc0) to head (eb69163). Report is 8 commits behind head on master.
:exclamation: Current head eb69163 differs from pull request most recent head d1b62dc. Consider uploading reports for the commit d1b62dc to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #5614 +/- ##
==========================================
- Coverage 48.16% 48.09% -0.08%
==========================================
Files 1438 1441 +3
Lines 31041 31075 +34
Branches 7594 7580 -14
==========================================
- Hits 14951 14945 -6
- Misses 16019 16061 +42
+ Partials 71 69 -2
| Files | Coverage Δ | |
|---|---|---|
| ...res/fastLogin/screens/AskUserInteractionScreen.tsx | 100.00% <100.00%> (ø) |
|
| ts/features/fastLogin/screens/FastLoginModals.tsx | 47.05% <0.00%> (+4.95%) |
:arrow_up: |
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4d49bdb...d1b62dc. Read the comment docs.
@mariateresaventura copy review needed 🙏
@mariateresaventura copy review needed 🙏
Done!