io-app icon indicating copy to clipboard operation
io-app copied to clipboard

feat: [IOPLT-359] Upgrade `react-native-svg` to 15.1.0 and `@pagopa/io-app-design-system` to 1.30.0

Open CrisTofani opened this issue 1 year ago β€’ 2 comments
trafficstars

Short description

This PR upgrades the version of react-native-svg to major 15 version. The upgrade of DS library is mandatory to avoid possible conflicts between the both libraries.

Upgrade of cocoapods has been introduced to support the podspecs of svg library pointing to visionos.

List of changes proposed in this pull request

  • Upgrade react-native-svg
  • Upgrade @pagopa/io-app-design-system
  • Upgrade cocoapods

How to test

Check the visualization of svgs on both Android and iOS.

Run following commands before running the app:

yarn install
gem install [email protected]
cd ios; pod install; cd ..
yarn run-ios

CrisTofani avatar Mar 20 '24 13:03 CrisTofani

Affected stories

  • 🌟 IOPLT-359: Come IO-PLATFORM voglio proporre l'aggiornamento react-native-svg per rendere possibile l'aggiornamento a react-native 0.71 subtask of
    • ⚑ IOPLT-36: Aggiornamento librerie base react native

Generated by :no_entry_sign: dangerJS against 10d742bf83ec93c8309919ee5ff3aeb836ed81e3

pagopa-github-bot avatar Mar 20 '24 13:03 pagopa-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.15%. Comparing base (49e2fc0) to head (5fc7e8d). Report is 10 commits behind head on master.

:exclamation: Current head 5fc7e8d differs from pull request most recent head 10d742b. Consider uploading reports for the commit 10d742b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5609      +/-   ##
==========================================
- Coverage   48.16%   48.15%   -0.02%     
==========================================
  Files        1438     1443       +5     
  Lines       31041    31121      +80     
  Branches     7594     7598       +4     
==========================================
+ Hits        14951    14985      +34     
- Misses      16019    16065      +46     
  Partials       71       71              

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update dc01ce1...10d742b. Read the comment docs.

codecov[bot] avatar Mar 22 '24 10:03 codecov[bot]

Shouldn't be better to bump the minimum cocopods version inside our Gemfile too? What do you think?

Maybe we could even consider a bundle update cocoapods. What do you think?

shadowsheep1 avatar Mar 26 '24 17:03 shadowsheep1

@shadowsheep1 good point! Just updated in 21260c7 as long as all it's deps, let me know if everything's fine πŸ˜‰

CrisTofani avatar Mar 27 '24 08:03 CrisTofani

@shadowsheep1 good point! Just updated in 21260c7 as long as all it's deps, let me know if everything's fine πŸ˜‰

@CrisTofani Good! And what about testing a deploy build (commenting the store upload) just to be sure it works anyway? What do you think?

shadowsheep1 avatar Mar 27 '24 08:03 shadowsheep1

@shadowsheep1 good point! Just updated in 21260c7 as long as all it's deps, let me know if everything's fine πŸ˜‰

@CrisTofani Good! And what about testing a deploy build (commenting the store upload) just to be sure it works anyway? What do you think?

@shadowsheep1 I guess an e2e test should be fine too since it builds a simulator instance running the bundle exec pod install before, or you're thinking about some fastlane issue?

CrisTofani avatar Mar 27 '24 08:03 CrisTofani

@shadowsheep1 good point! Just updated in 21260c7 as long as all it's deps, let me know if everything's fine πŸ˜‰

@CrisTofani Good! And what about testing a deploy build (commenting the store upload) just to be sure it works anyway? What do you think?

I guess an e2e test should be fine too since it builds a simulator instance running the bundle exec pod install before, or you're thinking about some fastlane issue?

@CrisTofani I'm actually just thinking about fastlane, right.

shadowsheep1 avatar Mar 27 '24 08:03 shadowsheep1

@shadowsheep1 running here https://github.com/pagopa/io-app/actions/runs/8448675159

CrisTofani avatar Mar 27 '24 08:03 CrisTofani

@shadowsheep1 done here aa11313

CrisTofani avatar Mar 27 '24 09:03 CrisTofani