io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore(Cross): [IOAPPX-256] Remove local ToastProvider

Open CrisTofani opened this issue 1 year ago • 3 comments

Short description

This PR aims to remove the local ToastProvider to use the one created in @pagopa/io-app-design-system

List of changes proposed in this pull request

  • Removed files and toasts invocation

How to test

Check all the usage in the app

CrisTofani avatar Feb 29 '24 14:02 CrisTofani

Affected stories

  • ⚙️ IOAPPX-256: Rimozione del context locale per i Toast message in app e sostituirlo con quello da @pagopa/io-app-design-system

Generated by :no_entry_sign: dangerJS against 90b18462c598c10f48c78cb7d0421f88bd0672dc

pagopa-github-bot avatar Feb 29 '24 14:02 pagopa-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.16%. Comparing base (9a968a0) to head (90b1846).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5557      +/-   ##
==========================================
+ Coverage   48.15%   48.16%   +0.01%     
==========================================
  Files        1443     1438       -5     
  Lines       31121    31041      -80     
  Branches     7598     7594       -4     
==========================================
- Hits        14985    14951      -34     
+ Misses      16065    16019      -46     
  Partials       71       71              
Files Coverage Δ
ts/components/NewRemindEmailValidationOverlay.tsx 74.76% <ø> (ø)
ts/features/barcode/screens/BarcodeScanScreen.tsx 1.44% <ø> (ø)
...res/bonus/cgn/components/detail/CgnUnsubscribe.tsx 6.25% <ø> (ø)
...omponents/detail/eyca/EycaInformationComponent.tsx 60.00% <ø> (ø)
...gn/components/detail/eyca/EycaPendingComponent.tsx 100.00% <ø> (ø)
...ponents/detail/eyca/EycaStatusDetailsComponent.tsx 50.00% <ø> (ø)
...nus/cgn/components/merchants/CgnDiscountDetail.tsx 48.48% <ø> (ø)
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 2.63% <ø> (ø)
...atures/design-system/core/DSToastNotifications.tsx 12.50% <ø> (ø)
ts/features/idpay/configuration/xstate/actions.ts 81.81% <ø> (ø)
... and 23 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a968a0...90b1846. Read the comment docs.

codecov[bot] avatar Feb 29 '24 15:02 codecov[bot]

LGTM. Tested in various app sections and it works like as expected.

dmnplb avatar Mar 14 '24 16:03 dmnplb