io-app
io-app copied to clipboard
chore(Cross): [IOAPPX-217] Add `NativeStackNavigator` to the Design System section
[!note] This PR depends on #5415
[!caution] This PR causes some issues to the
RootModalcomponent, as pointed out by @shadowsheep1: https://github.com/pagopa/io-app/pull/5415#pullrequestreview-1862965837
Short description
This PR adds the new NativeStackNavigator to the Design System section. This change enables a true native modal behaviour on iOS (including pull down to dismiss), other than a native navigation on both platforms.
List of changes proposed in this pull request
- Use
createNativeStackNavigatorto create the native navigator - Remove previously nested navigator thanks to the new API offered by the
6.xversion - Update
react-native-screens - Add the new
@react-navigation/native-stackpackage
Preview
https://github.com/pagopa/io-app/assets/1255491/b1877c26-12d0-44d6-b728-3296e87c33c7
How to test
Launch the local app and go to the Design System section
:tada: All dependencies have been resolved !
Affected stories
- ⚙️ IOAPPX-217: Aggiunta dello stack nativo alla sezione DS dopo l'upgrade di RN alla versione 6.x
subtask of- ⚡ IOAPPX-32: Design System
Generated by :no_entry_sign: dangerJS against ebcc7e75595e916e7498aeca5ab098f180904d6c
Codecov Report
Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.
Project coverage is 48.17%. Comparing base (
9f72690) to head (ba1cf49). Report is 12 commits behind head on master.
:exclamation: Current head ba1cf49 differs from pull request most recent head ebcc7e7. Consider uploading reports for the commit ebcc7e7 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #5424 +/- ##
==========================================
- Coverage 48.31% 48.17% -0.15%
==========================================
Files 1466 1461 -5
Lines 31114 30959 -155
Branches 7559 7518 -41
==========================================
- Hits 15034 14913 -121
+ Misses 16011 15978 -33
+ Partials 69 68 -1
| Files | Coverage Δ | |
|---|---|---|
| ...ures/bonus/common/screens/AvailableBonusScreen.tsx | 8.92% <ø> (ø) |
|
| ts/features/design-system/DesignSystem.tsx | 34.78% <ø> (ø) |
|
| ts/features/fci/hooks/useFciNoSignatureFields.tsx | 52.94% <ø> (ø) |
|
| ts/features/fci/navigation/FciStackNavigator.tsx | 75.00% <ø> (ø) |
|
| ...eatures/fci/screens/valid/FciDataSharingScreen.tsx | 70.45% <ø> (ø) |
|
| ...eatures/fci/screens/valid/FciQtspClausesScreen.tsx | 71.11% <ø> (ø) |
|
| ...features/messages/navigation/MessagesNavigator.tsx | 15.38% <ø> (ø) |
|
| ...res/messages/screens/LegacyMessageDetailScreen.tsx | 8.33% <ø> (ø) |
|
| ts/features/pn/components/MessageDetails.tsx | 90.00% <ø> (+2.50%) |
:arrow_up: |
| ts/features/pn/navigation/navigator.tsx | 18.18% <ø> (ø) |
|
| ... and 5 more |
... and 43 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7829b38...ebcc7e7. Read the comment docs.