io-app
io-app copied to clipboard
chore: [IAI-238] Add `LogoPayment…` components
Short description
⚠️ This PR depends on #4104
This PR adds LogoPayment… components (both small and big versions, managed as two different sets).
From now on, you can insert a "payment provider" logo in the following way:
// Insert the logo Mastercard, small version
// Default size: 24×24
<LogoPayment name="mastercard" />
Preview
Notes
- It doesn't support raster assets (PostePay, etc…) at the moment
- VPay logo is placed on the right to ensure consistency between different cards in the Wallet section
List of changes proposed in this pull request
- Add new
LogoPaymentcomponent with relative types - Add new
LogoPaymentExtcomponent (Ext stands for extended) with relative types - Add new
LogoPaymentViewerBoxto the Showroom section - Update general
README, add local one for documentation
How to test
- Start the IO app with
yarn run-ios - Login to the app
- Go to the Profile → UI Showroom
Affected stories
- ⚙️ IAI-238: Aggiunta di un componente per la gestione dei marchi di pagamento
subtask of
- ⚙️ IAI-222: Gestione degli asset (immagini, icone, pittogrammi)
Generated by :no_entry_sign: dangerJS against 8390e6d229ee4854ceb2180c5c46d0f77c647fd5
Codecov Report
Merging #4105 (8390e6d) into master (1d4595e) will increase coverage by
0.00%. The diff coverage is50.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #4105 +/- ##
=======================================
Coverage 47.59% 47.59%
=======================================
Files 1493 1528 +35
Lines 26543 26625 +82
Branches 6802 6806 +4
=======================================
+ Hits 12632 12673 +41
- Misses 13858 13899 +41
Partials 53 53
| Impacted Files | Coverage Δ | |
|---|---|---|
| ts/screens/showroom/Showroom.tsx | 28.57% <ø> (ø) |
|
| ts/screens/showroom/core/LogosShowroom.tsx | 40.00% <40.00%> (ø) |
|
| ts/components/core/logos/LogoPayment.tsx | 50.00% <50.00%> (ø) |
|
| ts/components/core/logos/LogoPaymentExt.tsx | 50.00% <50.00%> (ø) |
|
| ts/components/core/logos/svg/LogoPaymentAmex.tsx | 50.00% <50.00%> (ø) |
|
| .../components/core/logos/svg/LogoPaymentApplePay.tsx | 50.00% <50.00%> (ø) |
|
| ...mponents/core/logos/svg/LogoPaymentBancomatPay.tsx | 50.00% <50.00%> (ø) |
|
| ts/components/core/logos/svg/LogoPaymentDiners.tsx | 50.00% <50.00%> (ø) |
|
| .../components/core/logos/svg/LogoPaymentDiscover.tsx | 50.00% <50.00%> (ø) |
|
| ...s/components/core/logos/svg/LogoPaymentExtAmex.tsx | 50.00% <50.00%> (ø) |
|
| ... and 26 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1d4595e...8390e6d. Read the comment docs.
:tada: All dependencies have been resolved !