io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IAI-233] Remove deprecated NativeBase components related to typography

Open dmnplb opened this issue 3 years ago • 2 comments

Short description

⚠️ This PR depends on #4081

This PR removes some deprecated NativeBase components related to typography, in particular all the H… heading styles. It also removes some deprecated (and not used) generic variables from the variables.ts file.

List of changes proposed in this pull request

  • Remove H1, H2 and H3 original NativeBase components. All the previous references have been updated with the new H… components present in the core folder
  • Remove all the deprecated variables from variables.ts
  • Change reference to NativeBase Text component from Text to NBText
  • Add a comment to flag all the official theme variables used by NativeBase

How to test

  • Start the IO app with yarn run-ios
  • Login to the app

dmnplb avatar Jul 29 '22 14:07 dmnplb

Affected stories

  • ⚙️ IAI-233: Rimozione dei componenti legacy di Typography subtask of
    • ⚙️ IAI-216: Mappatura della tipografia

Generated by :no_entry_sign: dangerJS against a5056cafbf7f52092608298ede2cafde10be8347

pagopa-github-bot avatar Jul 29 '22 14:07 pagopa-github-bot

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.

github-actions[bot] avatar Oct 08 '22 02:10 github-actions[bot]

:tada: All dependencies have been resolved !

dpulls[bot] avatar Nov 07 '22 11:11 dpulls[bot]

Codecov Report

Merging #4093 (a5056ca) into master (1d2bb7c) will decrease coverage by 0.11%. The diff coverage is 51.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4093      +/-   ##
==========================================
- Coverage   47.83%   47.72%   -0.12%     
==========================================
  Files        1286     1286              
  Lines       25437    25386      -51     
  Branches     6655     6656       +1     
==========================================
- Hits        12169    12116      -53     
- Misses      13217    13219       +2     
  Partials       51       51              
Impacted Files Coverage Δ
ts/components/AdviceComponent.tsx 100.00% <ø> (ø)
ts/components/CalendarsListContainer.tsx 9.25% <ø> (ø)
ts/components/CopyButtonComponent.tsx 70.58% <ø> (ø)
ts/components/DetailedlistItemComponent.tsx 8.33% <ø> (ø)
ts/components/DevScreenButton.tsx 66.66% <ø> (ø)
ts/components/FiscalCodeComponent.tsx 85.29% <ø> (ø)
ts/components/LandingCardComponent.tsx 75.00% <ø> (ø)
ts/components/ListSelectionBar.tsx 75.00% <ø> (ø)
ts/components/LoadingSpinnerOverlay.tsx 100.00% <ø> (ø)
ts/components/OrganizationHeader.tsx 100.00% <ø> (ø)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d2bb7c...a5056ca. Read the comment docs.

codecov[bot] avatar Nov 07 '22 13:11 codecov[bot]