io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IAI-228] Remove/Update references to gradient values

Open dmnplb opened this issue 3 years ago • 2 comments
trafficstars

Short description

⚠️ This PR depends on #4075

This PR updates all the references to gradient color values, removing the unnecessary ones. All the gradients (except appIcon and appLaunch ones) are linked to the relative components. This means you can edit them in a single object (IOColorGradients)

Preview

Screenshot 2022-07-22 at 15 00 20

List of changes proposed in this pull request

  • Remove gradient values in the IOColors object
  • Remove deprecated yellow gradient
  • Add cgnAll gradient
  • Add reference to grey gradient in the DarkLayout component
  • Make IOColorGradients the single source of truth for all the gradients

How to test

  • Start the IO app with yarn run-ios
  • Login to the app
  • Go to the Profile → UI Showroom

dmnplb avatar Jul 22 '22 13:07 dmnplb

Affected stories

  • ⚙️ IAI-228: Eliminazione dei colori relativi al gradiente presenti in IOColors subtask of
    • ⚙️ IAI-215: Eliminazione delle variabili multiple dello stesso colore

Generated by :no_entry_sign: dangerJS against 2d6fb0626eae1130060473b54fadd146c9fac031

pagopa-github-bot avatar Jul 22 '22 13:07 pagopa-github-bot

Codecov Report

Merging #4076 (2d6fb06) into master (eea9ad4) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4076      +/-   ##
==========================================
+ Coverage   47.62%   47.63%   +0.01%     
==========================================
  Files        1275     1275              
  Lines       25153    25158       +5     
  Branches     6583     6583              
==========================================
+ Hits        11980    11985       +5     
  Misses      13123    13123              
  Partials       50       50              
Impacted Files Coverage Δ
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 2.63% <ø> (ø)
ts/features/bonus/cgn/utils/filters.ts 100.00% <ø> (ø)
ts/components/core/variables/IOColors.ts 100.00% <100.00%> (ø)
ts/components/screens/DarkLayout.tsx 54.16% <100.00%> (ø)
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx 13.95% <100.00%> (+2.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eea9ad4...2d6fb06. Read the comment docs.

codecov[bot] avatar Aug 01 '22 15:08 codecov[bot]

:tada: All dependencies have been resolved !

dpulls[bot] avatar Oct 27 '22 14:10 dpulls[bot]