io-app
io-app copied to clipboard
chore: [IAI-151] Update Authentication navigator
Short description
This PR updates the Authentication Navigator, in order to remove the compatibility layer.
https://user-images.githubusercontent.com/49342144/178779426-fc1912ed-3712-4c6b-99e1-648f21ad1459.mp4
List of changes proposed in this pull request
- Removed compatibility layer and created the new AuthenticationNavigator
- Refactored the navigation.navigate using new syntax
How to test
- start IO with
yarn run-ios - log in to IO
- logout from IO to repeat
Affected stories
- ⚙️ IAI-151: Aggiornare il navigator per l'Authentication
subtask of
- ⚡ IAI-143: Preparing for react-navigation v6
Generated by :no_entry_sign: dangerJS against 4e34c7150b07e65e68ef44620a811f14da98bfb2
Codecov Report
Merging #4056 (eff8a7b) into master (4c7f4a5) will decrease coverage by
0.00%. The diff coverage is11.11%.
:exclamation: Current head eff8a7b differs from pull request most recent head 4e34c71. Consider uploading reports for the commit 4e34c71 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #4056 +/- ##
==========================================
- Coverage 47.01% 47.01% -0.01%
==========================================
Files 1293 1293
Lines 25841 25842 +1
Branches 6894 6896 +2
==========================================
- Hits 12150 12149 -1
- Misses 13640 13642 +2
Partials 51 51
| Impacted Files | Coverage Δ | |
|---|---|---|
| ts/screens/authentication/CardSelectionScreen.tsx | 85.71% <ø> (ø) |
|
| ts/screens/authentication/IdpLoginScreen.tsx | 3.29% <ø> (ø) |
|
| ts/screens/authentication/IdpSelectionScreen.tsx | 22.22% <0.00%> (+1.53%) |
:arrow_up: |
| ts/screens/authentication/LandingScreen.tsx | 5.71% <0.00%> (ø) |
|
| ...creens/authentication/SpidCIEInformationScreen.tsx | 5.55% <ø> (ø) |
|
| ...s/screens/authentication/SpidInformationScreen.tsx | 33.33% <ø> (ø) |
|
| ...authentication/cie/CieAuthorizeDataUsageScreen.tsx | 7.14% <ø> (ø) |
|
| ...s/authentication/cie/CieConsentDataUsageScreen.tsx | 4.25% <0.00%> (ø) |
|
| ...s/authentication/cie/CieExpiredOrInvalidScreen.tsx | 28.57% <ø> (ø) |
|
| ...thentication/cie/CiePinLockedTemporarilyScreen.tsx | 0.00% <ø> (ø) |
|
| ... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9e6bfd1...4e34c71. Read the comment docs.
@CrisTofani it looks fine to me