laravel-google-structured-data-testing-tool
laravel-google-structured-data-testing-tool copied to clipboard
**[IMPROVEMENT]** Update dependency + auto detect ServiceProvider
In raising this pull request, I confirm the following (please check boxes):
- [x] I have read and understood the contributors guide.
- [x] I have checked that another pull request for this purpose does not exist.
- [x] I have considered, and confirmed that this submission will be valuable to others.
- [ ] I have added tests to prove that the code in this PR works.
Description
Couldn't install this because of your internal dependency of padosoft/support and Carbon. Updated that and AutoDiscover for the ServiceProvider.
Hi, thanks for the pr.
Unfortunately travis says that some check ware not successful the error is in composer.json: you write extra": { with one " please correct in "extra": { to make valid json.
See:
https://travis-ci.org/padosoft/laravel-google-structured-data-testing-tool/jobs/580107127
[Seld\JsonLint\ParsingException]
"./composer.json" does not contain valid JSON
Parse error on line 50:
...phpunit" }, extra": { "l
--------------------^
Expected: 'STRING' - It appears you have an extra trailing comma
Can you fix this? If you fix I accept the pull request.
thanks. Lorenzo.
Sry, it's 2am here 😅 Fixed.
Thanks for the quick reply
@lopadova bump :)