pact_broker icon indicating copy to clipboard operation
pact_broker copied to clipboard

Pact-Broker does not view Pacts with query matching

Open dervism opened this issue 7 years ago • 7 comments
trafficstars

Pre issue-raising checklist

I have already (please mark the applicable with an x):

  • [ x] Upgraded to the latest Pact Broker OR
  • [x ] Checked the CHANGELOG to see if the issue I am about to raise has been fixed

Software versions

Pact-Broker 2.24 to 2.27. Seeing same behaviour on the hosted Pact-Broker as well as my self hosted one. The hosted broker is running v2.24.0 (*.pact.dius.com.au)

Pact-JVM 3.5.23

Expected behaviour

Should show Pacts with query matching (v3 spec).

Actual behaviour

After upgrading to latests Pact-Broker my Pact is not visualised correctly. When I view pacts that has query maching, I get the following message at the top of the page:

"Note: this contract could not be parsed to a v1 or v2 Pact, showing raw content instead."

Downgrading to Pact-Broker 2.23 visualised the Pact correctly.

Steps to reproduce

See method "hasOnePersonQueryParam(...)" in this source file:

https://github.com/dervism/person-consumer/blob/master/src/test/java/no/dervis/pact/PersonServiceTest.java

The Pact is visualised correctly if I publish the Pact without the above mentioed method that has the query matching.

Relevent log files

person-consumer-person-provider.txt

dervism avatar Oct 04 '18 11:10 dervism

This surprises me, as I didn't think the broker ever supported rendering v3 pacts!

bethesque avatar Oct 23 '18 09:10 bethesque

I'm also seeing this issue. I upgraded from v2.24 to v2.27 and some of the pacts are displaying the same thing as described above.

bbarke avatar Dec 13 '18 23:12 bbarke

Hi, is this still a missing feature? I'm using version 2.43.0, and the problem seems to be still there. @bethesque would you review a pull request that would fix this?

tsayen avatar Jun 09 '20 15:06 tsayen

Yes, I would happily accept a PR.

Because I can't reproduce this issue myself, I need someone to submit a pact that causes the issue. I don't know which particular part of the v3 spec it's not parsing properly.

bethesque avatar Jun 10 '20 01:06 bethesque

Has a sufficient pull request been made as of this day? I'm running into the same issue.

JEFFTheDev avatar Feb 09 '22 14:02 JEFFTheDev

Also running into this issue :(

testifyqa avatar Mar 07 '22 10:03 testifyqa

Same issue here with a message pact with matchingRules,

  "metadata": {
    "pactSpecification": {
      "version": "3.0.0"
    },
    "pact-jvm": {
      "version": "3.6.15"
    }
  }

on a pact-broker-docker 2.93.2.0

ppetershagen avatar Mar 31 '22 08:03 ppetershagen