p4runtime
p4runtime copied to clipboard
Deprecate egress_port (uint32) in favor of egress (bytes) in Replica
This is to ensure consistency with the watch_port field. See https://github.com/p4lang/p4runtime/pull/317
Fixes #329
Hi @antoninbas, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:
✒️ 👉 https://cla.opennetworking.org
After signing, make sure to add your Github user ID antoninbas to the agreement.
For more information or help:" https://wiki.opennetworking.org/x/BgCUI
Bump. We are starting to use multicast. Would be great to get this submitted.
Bump. We are starting to use multicast. Would be great to get this submitted.
I don't mind merging this as it is. I know that other parts of the spec also needs to be tackled: the Index message, used to address Counter and Meter entries, should also support translation and its type should be changed to bytes (indexing a counter using a port value is a pretty common scenario). However, that can be done in a future PR.
@smolkaj I rebased the PR, could you take a look?