p4c icon indicating copy to clipboard operation
p4c copied to clipboard

lib/crash.cpp: `addr2line`: `fcntl` calls in `pipe` initializations fixed.

Open DoctorNoobingstoneIPresume opened this issue 3 years ago • 1 comments

Hi @DoctorNoobingstoneIPresume, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID DoctorNoobingstoneIPresume to the agreement.

For more information or help:" https://wiki.opennetworking.org/x/BgCUI

onf-cla-manager[bot] avatar May 09 '22 06:05 onf-cla-manager[bot]

Should we merge this? What is the reason for this change?

fruffy avatar Apr 14 '23 21:04 fruffy

Should we merge this? What is the reason for this change? The fix looks correct to me. we using F_SETFD and oring in FD_CLOEXEC so that should be used with F_GETFD instead of the current F_GETFL which seems wrong. FD flags vs FD status flags really. See https://man7.org/linux/man-pages/man2/fcntl.2.html .

apinski-cavium avatar Apr 14 '23 21:04 apinski-cavium