p4c
p4c copied to clipboard
lib/crash.cpp: `addr2line`: `fcntl` calls in `pipe` initializations fixed.
Hi @DoctorNoobingstoneIPresume, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:
✒️ 👉 https://cla.opennetworking.org
After signing, make sure to add your Github user ID DoctorNoobingstoneIPresume to the agreement.
For more information or help:" https://wiki.opennetworking.org/x/BgCUI
Should we merge this? What is the reason for this change?
Should we merge this? What is the reason for this change? The fix looks correct to me. we using F_SETFD and oring in FD_CLOEXEC so that should be used with F_GETFD instead of the current F_GETFL which seems wrong. FD flags vs FD status flags really. See https://man7.org/linux/man-pages/man2/fcntl.2.html .