p4-spec icon indicating copy to clipboard operation
p4-spec copied to clipboard

Improve and move operations on sets for Issue 969

Open MollyDream opened this issue 3 years ago • 4 comments

  • We added a section to define numeric types, which is later referred to when defining the argument types of sets and indexes.
  • We clarified the implicit casts of both set types and set operations.
  • We added examples of implicit casts for set operations in implicit casts.
  • We moved the section of Operations on sets before the section of Casts.
  • We adapted an existing example to generate a set of int<W>.

Fixes #969

MollyDream avatar Jan 03 '22 15:01 MollyDream

Hi @MollyDream, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID MollyDream to the agreement.

For more information or help:" https://wiki.opennetworking.org/x/BgCUI

onf-cla-manager[bot] avatar Jan 03 '22 15:01 onf-cla-manager[bot]

When merging, the description of bit-slicing should be shortened by referring to the "numeric types".

MollyDream avatar Feb 07 '22 17:02 MollyDream

As @QinshiWang suggests, maybe we want to rename the "numeric types" to "integral types".

MollyDream avatar Feb 07 '22 23:02 MollyDream

This PR contains two parts, (1) adding the concept of numeric types and cleaning the spec, and (2) adding explanations of set<T>. If not much labor is needed to separate them, we should do so.

QinshiWang avatar Mar 07 '22 21:03 QinshiWang

Subsumed by #1244.

jnfoster avatar Apr 25 '23 03:04 jnfoster