p-makowski

Results 11 comments of p-makowski

@Ig0r-M Fork this repository, push your changes to forked repo and create a pull request from it to this one.

@fredden I added issue id in my commits, so I believe issue and PR are linked already. But sure, I can add it in case it is not enough.

@fredden It was unclear to me when I read the documentation if it is about description, comments, commits... Thank you for clarification. I edited PR description, but I am still...

> I wonder if this is instead a bug in the tokeniser. @fredden see the last sentence in PR description: > \PHP_CodeSniffer\Tokenizers\GRAPHQL::tokenize adds \n to token content anyway (see vendor/magento/magento-coding-standard/PHP_CodeSniffer/Tokenizers/GRAPHQL.php:134)...

Code comment has been added @fredden

Hi @fredden , any ETA on getting it out?

> @p-makowski I have no control over Adobe's release process. Oh, sorry @fredden! Somehow I was sure that you are part of maintaining team

@sidolov When can we get any attention and hopefully a release?

@magento I am working on this