Preference buttons only substracting rows

[germanalvarez-personal]

The buttons on Preferences>General>Default dimensions> columns and rows both plus and less only substract rows on the GUI.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[White-Wolf]

I can confirm this issue. In addition, it seems changing almost anything (color scheme and theme dropdowns seem to be the only things that don't) in the Preferences window causes the window rows to decrease

[p-e-w]

Probably related to https://github.com/p-e-w/finalterm/issues/71.

Are you using Ubuntu? The PPA is outdated at the moment; I believe this issue was fixed in https://github.com/p-e-w/finalterm/commit/2a349712d670ef5378d4b607cd29b1e4e93aa4df. Please build from source if possible and try again.

[germanalvarez-personal]

Yes i'm using PPA in Ubuntu.

Sorry for the false report ....

[p-e-w]

Does compiling from source fix the problem?

[White-Wolf]

I have been trying to compile from source to test but have been running into compile-time errors around Clutter and Gee. I believe I have all required packages since cmake doesn't fail, but maybe something's misconfigured. make output:

cb@DevVM-ubuntu:~/Development/finalterm-master/build$ make
[  3%] Generating src/FinalTerm.c, src/Terminal.c, src/TerminalStream.c, src/TerminalOutput.c, src/CharacterAttributes.c, src/TerminalView.c, src/LineView.c, src/TerminalWidget.c, src/NestingContainer.c, src/Autocompletion.c, src/NotifyingList.c, src/ScrollableListView.c, src/Utilities.c, src/SettingsWindow.c, src/TextMenu.c, src/ColorScheme.c, src/Theme.c, src/KeyBindings.c, src/Command.c, src/Settings.c, src/Metrics.c
/home/cb/Development/finalterm-master/src/TerminalView.vala:140.10-140.35: error: The type name `Clutter.PropertyTransition' could not be found
    private Clutter.PropertyTransition blinking_animation;
            ^^^^^^^^^^^^^^^^^^^^^^^^^^
/home/cb/Development/finalterm-master/src/TerminalView.vala:572.10-572.42: error: The type name `Gee.SortedMap' could not be found
    private Gee.SortedMap<int, Clutter.Actor> y_index = new Gee.TreeMap<int, Clutter.Actor>();
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/home/cb/Development/finalterm-master/src/TerminalView.vala:664.46-664.59: error: The type name `Clutter.Matrix' could not be found
    protected override void apply_transform(ref Clutter.Matrix matrix) {
                                                ^^^^^^^^^^^^^^
Compilation failed: 3 error(s), 0 warning(s)
make[2]: *** [vala.stamp] Error 1
make[1]: *** [CMakeFiles/finalterm.dir/all] Error 2
make: *** [all] Error 2

cmake output:

cb@DevVM-ubuntu:~/Development/finalterm/build [master]$ cmake ..
-- The C compiler identification is GNU
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- checking for module 'unity'
--   found unity, version 5.12.0
-- checking for module 'libnotify'
--   found libnotify, version 0.7.5
-- checking for modules 'clutter-gtk-1.0;mx-1.0;keybinder-3.0;gee-1.0;unity;libnotify'
--   found clutter-gtk-1.0, version 1.2.0
--   found mx-1.0, version 1.4.3
--   found keybinder-3.0, version 0.3.0
--   found gee-1.0, version 0.6.4
--   found unity, version 5.12.0
--   found libnotify, version 0.7.5
-- Found Vala: /usr/bin/valac 
-- checking for a minimum Vala version of 0.16.0
--   found Vala, version 0.16.0
-- Found Gettext: /usr/bin/xgettext (found version "0.18.1")
-- Found Intltool: /usr/bin/intltool-extract (found version "0.50.2")
-- GSettings schemas will be installed locally.
-- GSettings shemas will be compiled.
-- GSettings schemas will be installed into /usr/local/share/glib-2.0/schemas/
-- Configuring done
-- Generating done
-- Build files have been written to: /home/cb/Development/finalterm/build

[p-e-w]

Final Term requires libgee >= 0.8. You have 0.6.4 only.

[p-e-w]

And you are correct of course, CMake should detect that. I'll look into it.

[White-Wolf]

So after taking forever to get a version of libgee >= 0.8 compiled for 12.04 (and then finding out vala already had a package on their PPA), I was finally able to try and recompile with your latest changes. Unfortunately, I am still running into compile-time errors with Clutter.

make output

[  3%] Generating src/FinalTerm.c, src/Terminal.c, src/TerminalStream.c, src/TerminalOutput.c, src/CharacterAttributes.c, src/TerminalView.c, src/LineView.c, src/TerminalWidget.c, src/NestingContainer.c, src/Autocompletion.c, src/NotifyingList.c, src/ScrollableListView.c, src/Utilities.c, src/SettingsWindow.c, src/TextMenu.c, src/ColorScheme.c, src/Theme.c, src/KeyBindings.c, src/Command.c, src/Settings.c, src/Metrics.c
/home/cb/Development/finalterm/src/TerminalView.vala:140.10-140.35: error: The type name `Clutter.PropertyTransition' could not be found
    private Clutter.PropertyTransition blinking_animation;
            ^^^^^^^^^^^^^^^^^^^^^^^^^^
/home/cb/Development/finalterm/src/TerminalView.vala:664.46-664.59: error: The type name `Clutter.Matrix' could not be found
    protected override void apply_transform(ref Clutter.Matrix matrix) {
                                                ^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 0 warning(s)
make[2]: *** [vala.stamp] Error 1
make[1]: *** [CMakeFiles/finalterm.dir/all] Error 2
make: *** [all] Error 2

cmake output

-- The C compiler identification is GNU
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- checking for module 'unity'
--   package 'unity' not found
-- checking for module 'libnotify'
--   found libnotify, version 0.7.5
-- checking for modules 'clutter-gtk-1.0;mx-1.0;keybinder-3.0;gee-0.8;libnotify'
--   found clutter-gtk-1.0, version 1.2.0
--   found mx-1.0, version 1.4.3
--   found keybinder-3.0, version 0.3.0
--   found gee-0.8, version 0.10.5
--   found libnotify, version 0.7.5
-- Found Vala: /usr/bin/valac 
-- checking for a minimum Vala version of 0.16.0
--   found Vala, version 0.16.0
-- Found Gettext: /usr/bin/xgettext (found version "0.18.1")
-- Found Intltool: /usr/bin/intltool-extract (found version "0.50.2")
-- GSettings schemas will be installed locally.
-- GSettings shemas will be compiled.
-- GSettings schemas will be installed into /usr/local/share/glib-2.0/schemas/
-- Configuring done
-- Generating done
-- Build files have been written to: /home/cb/Development/finalterm/build

Not sure if it matters, but I've noticed that cmake cannot find the Unity dev package, yet that doesn't break the build output. I've tried installing libunity-core-5.0-dev but that package requires the old gir1.2-gee-1.0 (gee 0.6.8) package, which causes conflicts with gee 0.10.5.