client icon indicating copy to clipboard operation
client copied to clipboard

Published 20 hours ago • verified publisher icon owncloud

Improve log message format

Open fmoc opened this issue 3 years ago • 7 comments

Helps making the log messages more readable, both for humans and machines.

Example log:

[2022/02/23 12:47:30,120] <gui.folder> INFO: Saved folder "1" to settings, status QSettings::NoError
[2022/02/23 12:47:30,120] <gui.folder.manager> INFO: Schedule folder  "1"  to sync!
[2022/02/23 12:47:30,120] <gui.folder.manager> INFO: Folder is not ready to sync, not scheduled!
[2022/02/23 12:47:30,121] <gui.application> INFO: Sync state changed for folder  "https://localhost:8443/remote.php/webdav/" :  "Not yet Started"
[2022/02/23 12:47:30,121] <sync.database.sql> DEBUG (OCC::SqlQuery::bindValue): SQL bind 1 3
[2022/02/23 12:47:30,121] <sync.database.sql> DEBUG (OCC::SqlQuery::exec): SQL exec "SELECT path FROM selectivesync WHERE type=?1"
[2022/02/23 12:47:30,121] <sync.clientproxy> INFO: Set proxy configuration to use system configuration

fmoc avatar Feb 23 '22 11:02 fmoc

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10866/5/1 :boom: The GUI tests failed. GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10866/guiReportUpload/index.html)
Server Logs: ((https://cache.owncloud.com/public/owncloud/client/10866/guiReportUpload/serverlog.log)

ownclouders avatar Feb 23 '22 12:02 ownclouders

I've included the proposed changes now.

I think that a more structured, table-like format would be even easier to read, but cannot be implemented just using the message format.

fmoc avatar Feb 24 '22 09:02 fmoc

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Feb 24 '22 09:02 sonarqubecloud[bot]

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10878/5/1 :boom: The GUI tests failed. GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10878/guiReportUpload/index.html)
Server Logs: ((https://cache.owncloud.com/public/owncloud/client/10878/guiReportUpload/serverlog.log)

ownclouders avatar Feb 24 '22 09:02 ownclouders

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 03 '22 21:04 sonarqubecloud[bot]

Sounds creepy, but a little documentation about what the format now is (imaging you would want to write a log viewer...) would be nice.

dragotin avatar May 13 '22 07:05 dragotin

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 13 '22 07:05 sonarqubecloud[bot]