client icon indicating copy to clipboard operation
client copied to clipboard

Add update information to the about dialog

Open erikjv opened this issue 1 year ago • 4 comments

Fixes: #11486

erikjv avatar Mar 11 '24 16:03 erikjv

@TheOneRing I'm not sure if we should move everything from the settings dialog to the about dialog. I think we should move the update part in the settings up higher, because it's probably more used than bandwidth limits.

For the about dialog: the text is customisable, so I added a label about the update status. We should probably also add a button or link text to redirect to the settings when there is an update available.

erikjv avatar Mar 11 '24 16:03 erikjv

Hmm the channel selection is only available in testpilotcloud so maybe we can move it to the about dialog?

TheOneRing avatar Mar 14 '24 16:03 TheOneRing

Hmm the channel selection is only available in testpilotcloud so maybe we can move it to the about dialog?

We can. I think it would give theming/design problems if we put it in the "about" tab, so maybe make a new (second) tab called "Updates" and put the contents of the QGroupBox in there? Also, I introduced that label at the bottom to draw more attention to updates, should that label stay? (See screenshot below.)

Screenshot 2024-03-18 at 14 03 41

erikjv avatar Mar 18 '24 13:03 erikjv

I think only the text can be branded, so it should be possible to add the info into the main widget.

TheOneRing avatar Mar 19 '24 08:03 TheOneRing

In the latest commit I moved all of the update stuff from the settings dialog to the about dialog. @TheOneRing How can I test this?

erikjv avatar Mar 27 '24 16:03 erikjv

Screenshot 2024-04-05 at 16 51 05

I'm not sure if I can get the version number out. I think it'd be useful to show that too.

erikjv avatar Apr 05 '24 14:04 erikjv

@TheOneRing The OCUpdater could provide the version. Should I add that in a separate PR?

erikjv avatar Apr 05 '24 14:04 erikjv

I'm not sure if I can get the version number out. I think it'd be useful to show that too.

So that was during testing. Meaning it passed the testing.

erikjv avatar Apr 08 '24 12:04 erikjv