idris-vimscript icon indicating copy to clipboard operation
idris-vimscript copied to clipboard

bring stack up to date, use Idris 1.2.0

Open ababkin opened this issue 7 years ago • 13 comments

ababkin avatar Dec 23 '17 00:12 ababkin

Thanks for the PR! We can't merge this as it stands because it's failing the Travis build (see here for why: likely formatting issues).

Outside of that, I think I'd prefer to track the latest version of Idris from Stackage rather than add things to extra-deps unless there's a clear benefit to using the latest available version of Idris.

mrkgnao avatar Dec 23 '17 19:12 mrkgnao

Thanks for the comment. I don't see anything in the travis log that tells me what went wrong. Exact same command stack install hlint stylish-haskell hindent idris builds fine locally. Idris 1.1.1 is mostly fixes and optimizations, which seem like good reasons.

ababkin avatar Dec 23 '17 19:12 ababkin

Could you possibly give me a hand fixing this? Or let me know how to go about fixing it?

ababkin avatar Dec 23 '17 20:12 ababkin

Oh, I'm so sorry:

Still running (30 of 30): stack install hlint stylish-haskell hindent idris
Timeout (30 minutes) reached. Terminating "stack install hlint stylish-haskell hindent idris"

I think the buildbot failed because compiling idris from source took too long.

mrkgnao avatar Dec 24 '17 09:12 mrkgnao

I think you should revert the Idris version bump for now. The other changes look good.

mrkgnao avatar Dec 24 '17 09:12 mrkgnao

@mrkgnao - It looks like stackage snapshots no longer contain idris package Short of continuing being on the old snapshot, the only way is using external deps

ababkin avatar Dec 24 '17 13:12 ababkin

@mrkgnao - have a question. I'd be happy to play around with the project and contribute, but I have a bit of a hard time starting and understanding the existing code. Is there a good material to read to get into this embedding idris into haskell? (I'm an advanced haskeller but only starting with Idris)

ababkin avatar Dec 25 '17 19:12 ababkin

cc @owickstrom: what should we do about this?

@ababkin: I'd suggest you first try looking at the parts that are less involved with the Idris compiler's API, like the optimizations and code transformations. That should give you a feel for what's going on.

mrkgnao avatar Dec 26 '17 19:12 mrkgnao

@mrkgnao Let me try this locally. I might be able to revive the Docker build I worked on to get the Travis build speed up.

owickstrom avatar Dec 26 '17 19:12 owickstrom

As a quick hack, I tried separating the installs of hindent and stylish-haskell from idris, which seems to have bypassed the timeout: https://travis-ci.org/owickstrom/idris-vimscript/builds/322139371

owickstrom avatar Dec 27 '17 12:12 owickstrom

I'm fiddling around with a Docker + cabal new-build based Travis build also.

owickstrom avatar Dec 27 '17 12:12 owickstrom

@mrkgnao @owickstrom - was just curious if you guys have figured out the above problem with Travis? Is there a setting for it to not timeout?

ababkin avatar Jan 26 '18 23:01 ababkin

I haven't had time to do more work on it. The last stuff is on https://github.com/owickstrom/idris-vimscript/tree/update-stack, where I think separating the installations of Idris and other tools helped a bit.

owickstrom avatar Jan 27 '18 07:01 owickstrom