Oskar Wickström

Results 150 comments of Oskar Wickström

Maybe the `StreamableBody` method could take the streaming consumer function as an argument, and directly changing the state of the request to `BodyRead`: ``` purescript class (Request req m) stream...

> I think the HeadersRead and BodyRead should be renamed to HeadersReadable and BodyReadable. Both convey the idea that those aspects are "readable" in that current state. The final transition...

Hi, thanks for the PR! Regarding the session IDs: I haven't had time to look that closely, but it seems inconsistent with the `SessionStore` class. If a consumer of the...

This is indeed an interesting proposal, and it has been on my TODO list before. :slightly_smiling_face: Not sure why there's no issue or note of it anywhere. As long as...

@rightfold Agreed. Not sure where you mean the functional dependency is, though?

Yes, you're absolutely right. I'll try loosening that, and adding some more instances. Regarding binary, I could add an instance for getting an `Aff e Buffer`, as with `String`. For...

Regarding this issue, it should only be about the `String` instance checking the Content-Type header and using that when doing `toString` on the buffer. Buffers in general, and streaming, are...

Yeah, maybe we should switch over to https://pursuit.purescript.org/packages/purescript-uri/4.0.0/docs/Data.URI.Query. I just skimmed it, but it seems to be the corresponding thing, but with a safe parser and type.

Sorry for unresponsiveness! Yeah, I think ultimately these form-related things shouldn't go in the core Hyper library. I did the initial versions a bit to feature-heavy just to try out...

I also hit this problem, but started wondering if effectful post-conditions wouldn't break the black box approach? As in @fisx's example with the database, to keep the database implementation a...