ModSecurity icon indicating copy to clipboard operation
ModSecurity copied to clipboard

build: don't directly use the .libs directory

Open orbea opened this issue 2 years ago • 2 comments

The build system should not directly use the .libs directory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the .la file should be used as this provides all the information required by the libtool implementation.

When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with.

Gentoo Bug: https://bugs.gentoo.org/913484

orbea avatar Sep 02 '23 20:09 orbea

@martinhsv Can you please review this PR? It should be straight forward.

orbea avatar Dec 13 '23 16:12 orbea

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 25 '24 21:01 sonarqubecloud[bot]

Hi @orbea,

thanks for sending for your first contribution!

Unfortunately for some reason, the regression tests didn't run when you sent this PR. Although the PR does not affect relevant parts, could you sent it again or add some minimal modification (fetch the newer version of the source tree), and commit that? Let me see that the CI starts now.

(I can't find even find your PR here).

Thanks!

airween avatar Feb 27 '24 19:02 airween

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 27 '24 20:02 sonarqubecloud[bot]

@airween I tried to rebase and force push the branch, but it failed on account of code duplication. So tried to make PR https://github.com/owasp-modsecurity/ModSecurity/pull/3097, but it needs maintainer approval.

orbea avatar Feb 27 '24 20:02 orbea

@orbea: would you mind to create a new PR from a fresh cloned repository?

I'm going to close this one - thanks for your effort!

airween avatar Mar 29 '24 10:03 airween