cfxlua-vscode icon indicating copy to clipboard operation
cfxlua-vscode copied to clipboard

Global/workspace Lua.workspace.library is merged with folder settings

Open Kaktus2225 opened this issue 2 years ago • 6 comments

When I set a path in Lua.workspace.library in workspace settings, it is copied by the extension (after restart) to user settings and only one of the natives is added (instead of three).

Kaktus2225 avatar May 19 '23 17:05 Kaktus2225

Now it works when there is a .code-workspace file, but when there is only settings.json is the same issue.

Kaktus2225 avatar May 20 '23 12:05 Kaktus2225

https://code.visualstudio.com/api/references/vscode-api#WorkspaceConfiguration

Represents the configuration. It is a merged view of Default Settings Global (User) Settings Workspace settings Workspace Folder settings - From one of the Workspace Folders under which requested resource belongs to. Language settings - Settings defined under requested language.

So I can only get a merged config object, but I can save to either global, workspace, or workspace folder. There's no way for me to check where the setting came from, and I cannot splice or push to an array of settings directly - only modify and update the merged object.

I have no clue how I'm supposed to resolve this.

thelindat avatar May 20 '23 13:05 thelindat

I have no clue how I'm supposed to resolve this.

You should consider getting added to LuaLS/LLS-Addons.

D4isDAVID avatar Jul 07 '23 04:07 D4isDAVID

I have no clue how I'm supposed to resolve this.

You should consider getting added to LuaLS/LLS-Addons.

Doesn't really solve anything and is less visible to users.

thelindat avatar Jul 08 '23 08:07 thelindat

Doesn't really solve anything and is less visible to users.

~~It would solve you having to mess with user settings in weird ways, since iirc addons don't write to the user's settings files~~ Not accurate I guess.

D4isDAVID avatar Jul 08 '23 09:07 D4isDAVID

~It would solve you having to mess with user settings in weird ways, since iirc addons don't write to the user's settings files~ Not accurate I guess.

Somehow only just saw this response but yeah it will still update user/workspace/folder settings.

I'm still, for some reason, holding out hope that Cfx do their own extension or LLS addon even though the issue is dead; so doing the addon myself would feel a bit awkward.

thelindat avatar Aug 18 '23 04:08 thelindat