Daniele Iasella

Results 84 comments of Daniele Iasella

@Meyazhagan as the package.json changed we need to update the snapshots for the dsg testing. Do you mind running `npx nx update-snapshot data-service-generator` ?

```ts resources.map(resource => { name: resource.name entities: entities.filter(entity => entity.targetResourceId === resource.id).map(entity => { name: entity.name }) }) ```

Test result ✅ ![Image](https://github.com/amplication/amplication/assets/2861984/13a41d45-b3b2-45af-a0ed-382540137c62)

The changes in general look good (apart from the nx command mistake). The only downside is that it won't force contributor to create separate PR for deployable as it won't...

@mulygottlieb @PazYanoverr this must be treated as top priority as it is in use

Test result ✅ ![Image](https://github.com/amplication/amplication/assets/2861984/38338042-e3f9-40be-89ab-30c9f61c220d)

Thanks @Meyazhagan! we will review it ASAP.

@Shurtu-gal yep, that will be necessary. Enterprise users currently have the ability to select the DSG version so they could stay with the current plugin versions but all others will...

@yuval-hazaz Moving this back as the change was reverted here due to a bug: - https://github.com/amplication/amplication/issues/8040 - https://github.com/amplication/amplication/pull/8039