rich-markdown-editor icon indicating copy to clipboard operation
rich-markdown-editor copied to clipboard

Published 20 hours ago • verified publisher icon outline

fix: allow / to be used anywhere, not just a new line

Open iamsaumya opened this issue 4 years ago • 2 comments

fixes #218

iamsaumya avatar Mar 20 '21 12:03 iamsaumya

Hey Tom, Please review this PR whenever you get some time. I don't have much confidence in the PR because I don't understand the codebase yet.

iamsaumya avatar Mar 23 '21 21:03 iamsaumya

This allows the menu to be triggered but the issue is more nuanced as previously it expects the current paragraph to be empty, using the same logic on a paragraph or other node that contains content will wipe it away or attempt to insert things in invalid locations.

There just needs to be some care about ensuring that the block insertion works as expected without losing any content whereever it's called from. The hovering menu itself also needs to be visually positioned next to the "/".

tommoor avatar Mar 24 '21 05:03 tommoor