LFO Process frequency values are different in the inspector and in the widget.

[guillaumeriousat]

trafficstars

The LFO process frequency values are in hertz (I empirically verified) in the widget and in some kind of strange scaling in the inspector.

I think they should be in hertz everywhere.

[jcelerier]

So for this issue I'd like to redo the LFO process in avendish as this grants better flexibility than the previous API this was implemented with.

I had started here : https://github.com/celtera/avendish/blob/3028a955d3489795848c389e8360ea0631b35989/examples/Advanced/Utilities/LFO.hpp#L12

The current code is there : https://github.com/ossia/score/blob/a96d6301131372e592b7b3ea295d1df675c2a49c/src/plugins/score-plugin-fx/Fx/LFO.hpp#L229

@guillaumeriousat would you be interested in looking into this ?

[guillaumeriousat]

Looking into this could be fun. How much do we need to care about compatibility with older patches ?

[jcelerier]

so the compatibility mechanism currently is :

• Processes have a different UUID
• Processes can have a "deprecated" flag. If they have this flag, the user cannot create new instances of them. But they will still be loaded in a given patch
• So the system keeps in memory the previous versions of the process for compat with older patch, but if you create an object you always get the last version (which has a different UUID than the previous one)
• A next step would be to have something like Ableton Live's feature which allows to upgrade a process to its new version, I have some rough draft prototypes for how to achieve this
• For a PR it's ok to just add a new object (or continue the "LFO X" object shared previously)