libossia icon indicating copy to clipboard operation
libossia copied to clipboard

[Ossia-max] v.2.0.0-rc load-time has increased by 10x from previouse version(s)

Open navid opened this issue 2 years ago • 11 comments

One of my patches that opens in 2.5 minuets with version "ossia-2022-11-20-17-18" now takes around 22 minutes with the latest v.2.0.0-rc

Similarly, another test patch by Peter that opens in 1 minute in version "2022-1-25-38" now takes 10 min to open.

All of this was triply tested and confirmed on three different machines by Evan, Navid, and Peter.

So we are going to a previous version of ossia now: 2022-1-25-38

navid avatar Dec 13 '22 18:12 navid

ossia-test-4osc.zip Here is my test patch that takes 10min to load on Ossia-max 2.0.0rc2, vs ~1min on Ossia "2022-1-25-38".

petervanhaaften avatar Dec 13 '22 18:12 petervanhaaften

I decided to force quit Max because it was taking >10 minutes to load the patch Peter just posted. Here's the crash log:

https://gist.github.com/evanmtp/d312d30e9095e4ae0f712f387decf6da

evanmtp avatar Dec 13 '22 18:12 evanmtp

Can you folk check that you don't have ossia.attribute objects in there ? I think this is what we had found that was causing the huge load times

jcelerier avatar Dec 13 '22 20:12 jcelerier

Also can you send me the commit number it says when you load 2022-1-25-38 in Max ?

jcelerier avatar Dec 13 '22 20:12 jcelerier

Hi yes thank you JMC. The Ossia commit number reads "build SHA : b69d06691". I can confirm there is no ossia.attribute involved.... I'm not sure yet what that object is about:)

petervanhaaften avatar Dec 13 '22 20:12 petervanhaaften

hmmm this is very weird, there's absolutely no difference in terms of general ossia max objects between https://github.com/ossia/libossia/commit/b69d0669114d58373a5958affbc15e8ee9df1cc9 and v2.0.0-rc2 ; ossia.cue has a few fixes but everything else did not change

jcelerier avatar Dec 13 '22 20:12 jcelerier

Hi I just reinstalled both versions and they read as... Ossia 2022-1-25-38 - build SHA : b69d06691 Ossia 2.0.00RC-2 - build SHA : 65c3eeb

On Tue, Dec 13, 2022 at 3:34 PM Jean-Michaël Celerier < @.***> wrote:

hm, this seems to be the commit of v2.0.0-rc2, not of 2022-1-25-38

— Reply to this email directly, view it on GitHub https://github.com/ossia/libossia/issues/813#issuecomment-1349648753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIZQHRYL52TH2AXW35323TWNDMXBANCNFSM6AAAAAAS5QRXMY . You are receiving this because you were assigned.Message ID: @.***>

petervanhaaften avatar Dec 13 '22 20:12 petervanhaaften

Hi JMC so that is interesting info re: small changes between https://github.com/ossia/libossia/commit/b69d0669114d58373a5958affbc15e8ee9df1cc9 & https://github.com/ossia/libossia/commit/65c3eebb47f504787c7bd05226d1f1e61a4d73fb We have tested this on 3 computers but in any case, I tested both versions again with the provided test patch. In https://github.com/ossia/libossia/commit/65c3eebb47f504787c7bd05226d1f1e61a4d73fb I see a load time of 10 minutes 22 seconds. In https://github.com/ossia/libossia/commit/b69d0669114d58373a5958affbc15e8ee9df1cc9 I see a load time of 1 minute 15 seconds. Very weird... indeed :))

petervanhaaften avatar Dec 13 '22 21:12 petervanhaaften

hmmm, I'm wondering if I may have left some stuff uncommmitted on my mac... are some of you in TML?

jcelerier avatar Dec 13 '22 21:12 jcelerier

Hiya not today, but we both should be around TML tomorrow....

petervanhaaften avatar Dec 13 '22 21:12 petervanhaaften

heya, ccan any of you try by removing the ossia.attribute.mxo object from the ossia package to check?

jcelerier avatar Dec 21 '22 23:12 jcelerier