libossia icon indicating copy to clipboard operation
libossia copied to clipboard

documentation : reflect namespace change for domain and other

Open avilleret opened this issue 6 years ago • 4 comments

in the documentation, there is :

auto dom = ossia::net::init_domain(ossia::val_type::INT);
ossia::net::set_values(dom, {-1, 1, 2, 3, 5, 10});
ossia::net::set_domain(node, dom);

but it seems that domain functions have been move from ossia::net to ossia namespace. maybe others also need check

The aboce should be :

auto dom = ossia::init_domain(ossia::val_type::INT);
ossia::set_values(dom, {-1, 1, 2, 3, 5, 10});
ossia::net::set_domain(node, dom);

avilleret avatar Jun 27 '19 07:06 avilleret

I was referring to https://ossia.github.io/#domain-min-max-set-of-values

avilleret avatar Jun 27 '19 10:06 avilleret

it's also worth notifying the needed includes :

#include <ossia/network/domain/domain.hpp>
#include <ossia/network/base/node_attributes.hpp>

avilleret avatar Nov 14 '19 22:11 avilleret

@jcelerier what do you suggest to fix this ? fixing the doc is easy but I found the ossia::set_values(dom, {-1, 1, 2, 3, 5, 10}); and init_domain quite annoying since those are the only static functions directly under the ossia name afaik, so it's not very consistent with others

but who cares ?

avilleret avatar Dec 24 '19 09:12 avilleret

huh, I think that putting them not in the ossia::net:: namespace was a mistake sorry ! Don't think it would break a lot of code to fix that :p

jcelerier avatar Dec 24 '19 10:12 jcelerier