libossia
libossia copied to clipboard
documentation : reflect namespace change for domain and other
in the documentation, there is :
auto dom = ossia::net::init_domain(ossia::val_type::INT);
ossia::net::set_values(dom, {-1, 1, 2, 3, 5, 10});
ossia::net::set_domain(node, dom);
but it seems that domain functions have been move from ossia::net to ossia namespace.
maybe others also need check
The aboce should be :
auto dom = ossia::init_domain(ossia::val_type::INT);
ossia::set_values(dom, {-1, 1, 2, 3, 5, 10});
ossia::net::set_domain(node, dom);
I was referring to https://ossia.github.io/#domain-min-max-set-of-values
it's also worth notifying the needed includes :
#include <ossia/network/domain/domain.hpp>
#include <ossia/network/base/node_attributes.hpp>
@jcelerier what do you suggest to fix this ?
fixing the doc is easy but I found the ossia::set_values(dom, {-1, 1, 2, 3, 5, 10}); and init_domain quite annoying since those are the only static functions directly under the ossia name afaik, so it's not very consistent with others
but who cares ?
huh, I think that putting them not in the ossia::net:: namespace was a mistake sorry ! Don't think it would break a lot of code to fix that :p