ort-ci-github-action icon indicating copy to clipboard operation
ort-ci-github-action copied to clipboard

Add ORT_HOME_PATH/cache to the locations for the GH cache

Open netomi opened this issue 1 year ago • 2 comments

Some package managers store downloaded artifacts in the ORT_HOME_PATH/cache directory for faster access after the first run, one example being the maven package manager.

Adding the .m2 directory as cache is not sufficient in this case, as the package manager will do a head request for all artifacts all the time unless it is found in the aforementioned cache.

Please ensure that your pull request adheres to our contribution guidelines. Thank you!

netomi avatar Dec 01 '23 19:12 netomi

Is this the (only) root cause of the slowness compared to pure Maven you mentioned over here?

sschuberth avatar Dec 01 '23 19:12 sschuberth

No that would only make subsequent runs of the action faster imho. The initial run might still be slow. However, I am not sure if this PR makes sense atm, as I realized that the cache is initialized by default with a maxCacheEntryAgeInSeconds of 6h.

netomi avatar Dec 01 '23 21:12 netomi

However, I am not sure if this PR makes sense atm, as I realized that the cache is initialized by default with a maxCacheEntryAgeInSeconds of 6h.

I guess it cannot hurt anyway.

sschuberth avatar Dec 16 '24 15:12 sschuberth