osmosis-frontend icon indicating copy to clipboard operation
osmosis-frontend copied to clipboard

Published 20 hours ago • verified publisher icon osmosis-labs

Incorrect liquidity value when one coin is not on coingecko

Open webmaster128 opened this issue 3 years ago • 1 comments

Hey there!

For pools where one asset is on Coingecko and the other is not, the "Pool Liquidity" and "My Liquidity" is calculated using the coingecko asset only. The other asset is valued at 0.

This is misleading to users. Assuming the pool is more or less balances out, the Liquidity value is only half of what it should be.

Would it be possible to use the listed token as 50% of the value and calculate the Liquidity that way?

webmaster128 avatar Jul 19 '22 12:07 webmaster128

I can fix this issue via https://github.com/osmosis-labs/osmosis-frontend/pull/720. But I guess there yould be an easier fallback when the price of one side of the pool is unknown.

webmaster128 avatar Aug 09 '22 15:08 webmaster128

Do you have an example pool where this takes effect?

jonator avatar Aug 30 '22 13:08 jonator

Pool 769 before #720 was merged. Only OSMO had a coingecko price, but TGD did not.

webmaster128 avatar Aug 30 '22 14:08 webmaster128