osmosis-frontend icon indicating copy to clipboard operation
osmosis-frontend copied to clipboard

(Deposit/Withdraw) Support connection error transfer status in transfer UI

Open jonator opened this issue 1 year ago • 2 comments

What is the purpose of the change:

Linear Task

Linear Task URL

Brief Changelog

  • Migrate to transfer status type from bridge package in UI, adapt to legacy IBC transfer status history store
  • Minor cleanup of interchain balances tRPC query

Testing and Verifying

Transfer statuses are visible in table, including connection error types

jonator avatar Jul 05 '24 18:07 jonator

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 5:16pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 5:16pm
osmosis-frontend-dev ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 5:16pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Jul 8, 2024 5:16pm
osmosis-testnet ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 5:16pm

vercel[bot] avatar Jul 05 '24 18:07 vercel[bot]

Walkthrough

The changes involve updating data transformation logic, fixing/enhancing status handling, and refactoring value initialization across multiple files. Specifically, TransferHistoryTable and related status display logic now use TransferStatus. Additionally, the usdValue initialization is cleaned up by removing unnecessary Dec wrappers in local-bridge-transfer.ts. Overall, the refactor enhances the data handling consistency and code readability.

Changes

Files Change Summary
packages/.../table/transfer-history.tsx Updated data fetching to use useRecentTransfers, replaced IBCTransferHistoryStatus with TransferStatus, and revamped status display logic.
packages/.../transactions/recent-transfers.tsx Modified logic to determine simplifiedStatus, adapting from "complete" and "timeout" to "success" and "connection-error".
packages/.../transactions/use-recent-transfers.ts Refactored RecentTransfer type to use TransferStatus; adjusted status assignment logic in useRecentTransfers function.
packages/.../api/routers/local-bridge-transfer.ts Simplified usdValue initialization by replacing new Dec(0) with 0 and usdValue ?? new Dec(0) with usdValue ?? 0; removed redundant Dec wrappers.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 05 '24 18:07 coderabbitai[bot]

@JoseRFelix what's the plan with fixing the swap tool test? It's worth noting that this is getting replaced by new trade flow very soon as well.

jonator avatar Jul 06 '24 19:07 jonator

@jonator I approved the PR. By the way, the build is failing because the chainlist added an unexpected property. @JeremyParish69 is working on it

JoseRFelix avatar Jul 08 '24 16:07 JoseRFelix