only enable ICNS address check for mainnet

[mattupham]

What is the purpose of the change:

Linear Task

Linear Task URL

Brief Changelog

Testing and Verifying

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2024 2:23am

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Jun 21, 2024 2:23am
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Jun 21, 2024 2:23am
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Jun 21, 2024 2:23am

[coderabbitai[bot]]

Walkthrough

The recent update introduces a conditional check for the IS_TESTNET variable in the useICNSName hook. This ensures that the query is only enabled when the application is not running on a testnet. This change guarantees that the ICNS name resolution is skipped during testnet usage, likely for performance or relevance reasons.

Changes

File	Summary of Changes
packages/web/hooks/queries/osmosis/use-icns-name.ts	Added import { IS_TESTNET } from "~/config"; and adjusted the enabled condition to !IS_TESTNET && Boolean(address).

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant useICNSName
    participant IS_TESTNET

    App->>+useICNSName: Call hook with address
    useICNSName->>+IS_TESTNET: Check if IS_TESTNET is true
    IS_TESTNET-->>-useICNSName: Return true/false
    useICNSName->>+App: Enable query only if !IS_TESTNET && address is valid

Poem

In the land of code where bytes entwine,
Queries now heed the testnet sign. 🌐
A gentle check, a thoughtful gate,
To skip the test when in that state.
Data flows with purpose, clear and bright,
Making sure our queries function right.
Happy coding, day and night! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between fc6f9d348f3e8fe2e3e471f59bd38679e8fc5499 and c079c1252da2f7587dfc3c0c635f4589af9574b0.

Files selected for processing (1)

• packages/web/hooks/queries/osmosis/use-icns-name.ts (1 hunks)

Additional comments not posted (2)

packages/web/hooks/queries/osmosis/use-icns-name.ts (2)

4-4: Import Statement Reviewed: Looks good!

The import of IS_TESTNET from ~/config is correctly placed and formatted.

---

11-11: Condition Update Reviewed: Logical change appears sound.

The update to the enabled condition to include !IS_TESTNET ensures that the query does not run on testnets, which aligns with the PR's objectives. However, consider adding a comment explaining why this condition is important for clarity and maintainability.

[REFACTOR_SUGGESTion]

// Disable query on testnets to prevent unintended operations or data exposure
enabled: !IS_TESTNET && Boolean(address) && typeof address === "string",

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mergify[bot]]

⚠️ The sha of the head commit of this PR conflicts with #3362. Mergify cannot evaluate rules on this PR. ⚠️

[MaxMillington]

@mattupham status on this?