osmosis-frontend icon indicating copy to clipboard operation
osmosis-frontend copied to clipboard

Support user assets lists

Open jonator opened this issue 3 years ago • 8 comments

Problem

The number of tokens being added to osmosis is increasing quickly. It's becoming unwieldy to navigate the various IBC assets available for trade (even with sort & search UI). We are currently suffering from the necessary "gatekeeping" problem; new assets are currently enabled by the core dev team, thus stifling the speed of liquidity for innovation.

Solution

Inspired by Uniswap, there should be a place on the frontend where users can easily select the assets that are visible.

Requirements:

  • UX should not be confusing to new/non-power users (put under gear icon on trade clipboard? & bottom of assets page?)
    • There should be a default assets list that contains assets recommended by the team (similar to the current list, could be called "Recommended")
  • Users should be able to select multiple lists, and conflicts should throw an error
  • (Stretch) Power users should be able to add their own assets list via a URL to a JSON file

Long term- we should seek to add metadata on chain to be updated via governance proposals. This would grant us the added benefit of officiated token denoms.

jonator avatar Feb 23 '22 04:02 jonator

One thing we need to decide is whether the custom assetlists will only apply to the trade page's token selection, or globally across the web app (i.e. pools page and assets page).

dogemos avatar Mar 03 '22 04:03 dogemos

Right now I think the token lists should only apply to the trade + asset page, with a separate UI displayed to guide users (i.e. 'Not seeing tokens you're looking for?') that could guide users to modify the assetlist if the user doesn't see the asset they are looking for.

dogemos avatar Mar 03 '22 05:03 dogemos

I think it should apply to everything. Like it should at least re-label tokens on the pools page based off of the assetlist

sunnya97 avatar Mar 10 '22 20:03 sunnya97

I think it should apply to everything. Like it should at least re-label tokens on the pools page based off of the assetlist

@sunnya97 how important is it for newly listed assets to be visible? I can imagine if a user's assetlist is always filtering his UI, that the user will potentially miss a listing... this is the "other extreme" .

A suggestion: perhaps, in certain interfaces, the user assetlist could be implemented more like a "priority list" or "favourites" - e.g. a user's assets can be bumped to the top of the assets page & trading dropdowns...

jasbanza avatar Mar 25 '22 23:03 jasbanza

I think that's okay. People will likely learn about new listings from other sources, not from the assets page itself. The assets page will show new listings that are added to the default list

sunnya97 avatar Mar 26 '22 19:03 sunnya97

@sunnya97 @jonator I'm not sure if this has been previously discussed elsewhere, if not now, perhaps consider this for later?

Asset "category" filters: Be able to filter your assets / trade list by the following:

  • SDK Native
  • Juno CW-20s
  • Secret SNIP-20s
  • Evmos ERC-20s
  • Any other ecosystem / bridge filters that come later...

jasbanza avatar May 07 '22 11:05 jasbanza

  • [ ] Look into ways to incorporate chain registry as we work on this project #158 #63
  • [ ] Revert hardcoded frontier work (https://github.com/osmosis-labs/osmosis-frontend/pull/488/commits/9a16a0cac8b005e23c1b8be6669be9d30c60f777) by making "Frontier" it's own assets list (the 'everything' list)

jonator avatar May 12 '22 23:05 jonator

5/31 meeting - this may be deprioritized and kicked down the road. With the frontier site and the asset/pools filter/sorting, it's harder to justify such a large overhaul to the UI. This may become more important as we add more assets to Osmosis (when assets are in the hundreds on frontier).

jonator avatar May 31 '22 17:05 jonator

Closing in favor of tracking on ClickUp

jonator avatar Apr 28 '23 20:04 jonator