osmosis-frontend icon indicating copy to clipboard operation
osmosis-frontend copied to clipboard

[DRAFT] Claim rewards for all positions directly from the pools page

Open nicolaslara opened this issue 2 years ago • 7 comments

What is the purpose of the change

ClickUp Task

ClickUp Task URL

Brief Changelog

Testing and Verifying

Documentation and Release Note

Summary by CodeRabbit

  • New Features

    • Introduced a feature to send rewards messages for all positions within the Osmosis account.
    • Added a "Claim All Rewards" button component for users to easily claim rewards from Osmosis pools.
    • Integrated feature flag for concentrated liquidity, enhancing future feature rollouts and testing.
  • Refactor

    • Enhanced liquidity position querying capabilities in the Osmosis account implementation.

nicolaslara avatar Nov 13 '23 22:11 nicolaslara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 1:49pm
osmosis-frontend-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 1:49pm
osmosis-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 1:49pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2024 1:49pm
temp-osmosis-frontend-proxy-test ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2024 1:49pm

vercel[bot] avatar Nov 13 '23 22:11 vercel[bot]

@nicolaslara is this still being worked on?

MaxMillington avatar Jan 02 '24 21:01 MaxMillington

No. Worked on this in NJ and should be ready for review / merge. The only thing left should be deciding where to position the button

nicolaslara avatar Jan 03 '24 03:01 nicolaslara

@nicolaslara can you sync with Nass on this? I recommend making a proposal for him to review.

MaxMillington avatar Jan 03 '24 21:01 MaxMillington

Closing as stale, can reopen later

jonator avatar Feb 26 '24 18:02 jonator

Reopened.

We probably want to move the button up. It would also be good for someone from the FE team to take a look at the code. This made sense in Nov when I wrote it, but a lot of things have changed in the FE architecture since then

Cursor_and_Gather_Mini_Mode

nicolaslara avatar Mar 11 '24 13:03 nicolaslara

Walkthrough

These updates introduce enhancements to the Osmosis account functionality and user interface. A key feature added is the ability for users to send rewards messages for all positions in the Osmosis pools directly from their account. Additionally, a new React component, ClaimAllRewardsButton, has been implemented to streamline the process of claiming rewards on the web interface, complemented by a feature flag for concentrated liquidity and integration into the pools page for user convenience.

Changes

File Path Change Summary
.../osmosis/index.ts Introduced imports for handling liquidity positions and sending rewards messages.
.../components/buttons/claim-all-rewards.tsx New file for the ClaimAllRewardsButton React component to claim rewards.
.../hooks/use-feature-flags.ts Added a feature flag for concentrated liquidity.
.../pages/pools.tsx Integrated the ClaimAllRewardsButton into the MyPoolsSection.

🐰✨
In the land where code does weave,
A rabbit hopped, you best believe.
"Claim your rewards," it softly said,
With every jump, ahead it led.
Through pools and tokens, wide and far,
Under the glow of the code star.
🌟🚀🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Mar 11 '24 13:03 coderabbitai[bot]

closing as stale, can reopen, and could use some design input

jonator avatar Apr 19 '24 15:04 jonator