osmlint icon indicating copy to clipboard operation
osmlint copied to clipboard

Undetected crossinghighways

Open maning opened this issue 7 years ago • 3 comments

We are seeing cases of undetected crossinghighways. Posting stub ticket as we investigate the problem.

To replicate.

  1. Download latest qa-tiles
  2. osmlint crossinghighways --zoom=12 --bbox="[-88.3265, 41.4343, -87.1057, 42.2823]" united_states_of_america.mbtiles > crossinghighways-chicago.json
  3. Inspect in your own data browser of choice.
  • results
  • expected detection should include this way.

@srividyacb

maning avatar Jul 19 '18 06:07 maning

@maning you are right. looks like the issue is here: https://github.com/osmlab/osmlint/blob/master/validators/crossingHighways/map.js#L156-L174, since the way https://www.openstreetmap.org/way/597384240/history is not forming a segment to check if those roads are intersecting, we may need a way to check if an object has the same start and the end coordinates. it must resolve the issue.

Rub21 avatar Jul 20 '18 17:07 Rub21

@Rub21 thanks for the hint!

https://github.com/osmlab/osmlint/blob/master/validators/crossingHighways/map.js#L156-L174

Can you explain what ^^ line do?

maning avatar Jul 23 '18 08:07 maning

@maning the code line: https://github.com/osmlab/osmlint/blob/master/validators/crossingHighways/map.js#L68, is evaluating if two highways are intersecting, according to the starts and end coordinates, so in case the start and the end coordinates are the same it won't be intersecting with the others neighbors roads.

Rub21 avatar Aug 02 '18 13:08 Rub21