Otto van der Schaaf
Otto van der Schaaf
When the code for handling effective configuration in extensions is [consolidated]( https://github.com/envoyproxy/nighthawk/issues/498) there might be an opportunity to optimize: Each of our extensions independently read, validate and compute effective configuration...
In our tests that ensure we are able to transform Nighthawk's native output format to Fortio's, we use rather arbitrary and large sample data, see [input](https://github.com/envoyproxy/nighthawk/blob/master/test/test_data/output_formatter.medium.proto.gold) and the corresponding [output](https://github.com/envoyproxy/nighthawk/blob/master/test/test_data/output_formatter.medium.fortio.gold)....
While adding test coverage for the extensions with respect to handling entity bodies, an issue was observed with the dynamic delay extension: POST requests with entity bodies that exceed a...
When adding an include from a directory not explicitly specified in our check_format scrips, the automatic formatting fixing may produce output that gets flagged by the formatting check. That's less...
In our `BUILD` files, in `envoy_cc_library`, we have lots of repetition with respect to declaring visibility of targets. It would be nice if we could set this at the package...
Leaving a note here inspired by the discussion over at https://github.com/envoyproxy/nighthawk/pull/477#discussion_r476803233 Tracking the delta's between inbound requests per worker at the test server may yield interesting data. In particular, it...
Today, we run asan and tsan in CI, but msan was a little hard to get up and running as it has special requirements around linking to an instrumented build...
In https://github.com/envoyproxy/nighthawk/pull/406 we added tasks and enhanced support for generation a compilation database (`compile_comands.json`), in anticipation for setting up IDE c++ code autocomplete and code navigation / refactoring. To make...
In https://github.com/envoyproxy/nighthawk/pull/412 two clang-tidy checks have been disabled. It's possible that Envoy may revert back to c++14, and until we are sure that won't happen, we should probably not rely...
Observed a CI run associated to https://github.com/envoyproxy/nighthawk/pull/316 ``` [ RUN ] ClientTest.AutoConcurrencyRun [14:11:50.442223][31224][C] [source/client/process_impl.cc:124] assert failure: shutdown_. Details: shutdown not called before destruction. [14:11:50.448097][31224][C] [bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:83] Caught Aborted, suspect faulting address...